[2.8] fix: remove draining from Flush callback (#7420)#7525
Merged
Conversation
* fix: remove draining from Flush callback * test: add test for query while flushall * improve testing with workers * improve test (cherry picked from commit e56bf5b)
JoanFM
changed the title
alonre24
previously approved these changes
Nov 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7525 +/- ##
==========================================
- Coverage 87.54% 87.52% -0.03%
==========================================
Files 203 203
Lines 34925 34924 -1
==========================================
- Hits 30575 30567 -8
- Misses 4350 4357 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- secret-detection-trufflehog
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
alonre24
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #7420 to 2.8
Note
Remove worker-thread draining from the FlushDB callback and add a stress test for querying during FLUSHALL under MT mode.
onFlush(src/spec.c), leaving index/metadata cleanup intact.tests/pytests/test_query_while_flush.pyto stress concurrent queries acrossFLUSHALL, validating old index errors and new index functionality under MT mode.Written by Cursor Bugbot for commit 4348f52. This will update automatically on new commits. Configure here.