[2.10] fix: remove draining from Flush callback (#7420)#7524
Merged
Conversation
* fix: remove draining from Flush callback * test: add test for query while flushall * improve testing with workers * improve test (cherry picked from commit e56bf5b)
JoanFM
force-pushed
the
backport-7420-to-2.10
branch
from
6682f9b to
c7b75b0
Compare
JoanFM
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7524 +/- ##
==========================================
- Coverage 89.33% 89.29% -0.04%
==========================================
Files 207 207
Lines 35448 35447 -1
==========================================
- Hits 31667 31654 -13
- Misses 3781 3793 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #7420 to 2.10
Note
Remove worker-thread draining during FLUSHDB flush and add a multithreaded test validating query behavior across FLUSHALL.
onFlushinsrc/spec.c: stop draining worker thread pool (workersThreadPool_Drain) onFLUSHDB_START.tests/pytests/test_query_while_flush.pyto stress-query an index before/afterFLUSHALL, then create a new index and validate expected errors/successes.Written by Cursor Bugbot for commit c7b75b0. This will update automatically on new commits. Configure here.