Conversation
LukeMathWalker
added
enforce:coverage
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
All nightly-related references to build.sh have been updated to use .rust-nightly as the source of truth.
It gets rid of unnecessary rebuilds, since the nightly version was the only thing we cared about from `build.sh` when building the container.
Using a specific version, the CI container is correctly rebuilt whenever that version changes. It also moves the Rust toolchain file to the root of the repository, to ease copying it into the container during build.
LukeMathWalker
force-pushed
the
rust-ci-improvements
branch
from
e5dc115 to
085ddea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7520 +/- ##
==========================================
- Coverage 85.00% 84.87% -0.13%
==========================================
Files 349 349
Lines 53877 53873 -4
Branches 14384 14380 -4
==========================================
- Hits 45797 45724 -73
- Misses 7884 7957 +73
+ Partials 196 192 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Triggered a build on all platforms: https://github.com/RediSearch/RediSearch/actions/runs/19699638714 |
meiravgri
approved these changes
Nov 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7520-to-8.2 origin/8.2
cd .worktree/backport-7520-to-8.2
git switch --create backport-7520-to-8.2
git cherry-pick -x 7bc0ece6d10445dccdab9c0ffdce9f2f48418ceb |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
* Move nightly version to a standalone .rust-nightly file. All nightly-related references to build.sh have been updated to use .rust-nightly as the source of truth. * Copy `.rust-nightly` rather than `build.sh` into the CI container. It gets rid of unnecessary rebuilds, since the nightly version was the only thing we cared about from `build.sh` when building the container. * Use a specific stable version of Rust. Using a specific version, the CI container is correctly rebuilt whenever that version changes. It also moves the Rust toolchain file to the root of the repository, to ease copying it into the container during build. * Cache Rust packages in CI. * Only use the cache action if Node is supported. * Trigger build with cache hit (cherry picked from commit 7bc0ece)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
* Rust CI improvements (#7520) * Move nightly version to a standalone .rust-nightly file. All nightly-related references to build.sh have been updated to use .rust-nightly as the source of truth. * Copy `.rust-nightly` rather than `build.sh` into the CI container. It gets rid of unnecessary rebuilds, since the nightly version was the only thing we cared about from `build.sh` when building the container. * Use a specific stable version of Rust. Using a specific version, the CI container is correctly rebuilt whenever that version changes. It also moves the Rust toolchain file to the root of the repository, to ease copying it into the container during build. * Cache Rust packages in CI. * Only use the cache action if Node is supported. * Trigger build with cache hit (cherry picked from commit 7bc0ece) * fix: Avoid Rust cache contamination across platforms. (#7569) --------- Co-authored-by: Luca Palmieri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Optimize the Rust build setup for maximum Docker cacheability.
Add package caching to platforms that can run the corresponding GitHub action.
Mark if applicable
Note
Centralizes the pinned Rust nightly via
.rust-nightly, adds a rootrust-toolchain.toml, and enables GitHub Actions cargo caching to speed Rust tests.Swatinem/rust-cache@v2(workspacesrc/redisearch_rs -> ../../bin/redisearch_rs)..rust-nightlyinstead of hardcoded values:build.sh,.install/test_deps/install_rust_deps.sh,tests/deps/setup_rejson.sh; print nightly version during coverage runs.rust-toolchain.toml(channel1.91.1); removesrc/redisearch_rs/rust-toolchain.toml..rust-nightlyto pin nightly (nightly-2025-07-30)..dockerignoreto include.rust-nightlyandrust-toolchain.tomlin build context.Written by Cursor Bugbot for commit 58364ec. This will update automatically on new commits. Configure here.