[8.4] fix: remove draining from Flush callback#7471
Merged
redisearch-backport-pull-request[bot] merged 2 commits into8.4from Nov 26, 2025
Merged
[8.4] fix: remove draining from Flush callback#7471redisearch-backport-pull-request[bot] merged 2 commits into8.4from
redisearch-backport-pull-request[bot] merged 2 commits into8.4from
Conversation
* fix: remove draining from Flush callback * test: add test for query while flushall * improve testing with workers * improve test (cherry picked from commit e56bf5b)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7471 +/- ##
==========================================
+ Coverage 85.78% 85.85% +0.06%
==========================================
Files 330 330
Lines 52442 52464 +22
Branches 12001 12001
==========================================
+ Hits 44989 45043 +54
+ Misses 7286 7254 -32
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Nov 26, 2025
redisearch-backport-pull-request
bot
deleted the
backport-7420-to-8.4
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7420 to
8.4.Note
Removes
workersThreadPool_Drainfrom the FlushDBonFlushcallback and adds a test validating query behavior acrossFLUSHALL.workersThreadPool_Drain(ctx, 0)fromonFlushinsrc/spec.c, leaving onlyIndexes_Free,Dictionary_Clear, and stats reset.tests/pytests/test_query_while_flush.pyto stress queries during and afterFLUSHALL, verifying errors/successes before/after and new index functionality.Written by Cursor Bugbot for commit ca352a7. This will update automatically on new commits. Configure here.