[2.8] Fix Fork GC potential double-free on error path - [MOD-12521]#7462
Merged
[2.8] Fix Fork GC potential double-free on error path - [MOD-12521]#7462
Conversation
* make FGC_recvBuffer clean * add revents to timeout log * improve polling logs * Nullify tag field name * remove unused variable * add a test * add a stres unit-test * improve test * improve logging * add include (cherry picked from commit 442a75e)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7462 +/- ##
==========================================
+ Coverage 87.49% 87.53% +0.03%
==========================================
Files 203 203
Lines 34812 34925 +113
==========================================
+ Hits 30458 30570 +112
- Misses 4354 4355 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7423 to
2.8.Note
Improves Fork GC pipe read/write error handling and memory safety, and adds tests that simulate pipe failures during GC/apply.
FGC_sendFixed: usefgc->ctxfor logging and exit viaRedisModule_ExitFromChildon broken pipe.FGC_recvFixed: robust poll/read loop with explicitpoll_rchandling and detailed diagnostics (errno,revents).FGC_recvBuffer: refactor to use a temporary length and buffer; fix allocation/free paths to avoid double-free and correctly set out params.fieldNametoNULL; remove unused pre-fork PID.testPipeErrorDuringGCandtestPipeErrorDuringApplyto simulate pipe closures/errors and verify graceful handling without crashes or double-frees.Written by Cursor Bugbot for commit 2419517. This will update automatically on new commits. Configure here.