Skip to content

[2.10] [MOD-12263] Enhance FT.PROFILE with vector search execution details (#7436)#7448

Merged
meiravgri merged 4 commits into2.10from
backport-7436-to-2.10
Nov 20, 2025
Merged

[2.10] [MOD-12263] Enhance FT.PROFILE with vector search execution details (#7436)#7448
meiravgri merged 4 commits into2.10from
backport-7436-to-2.10

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Nov 20, 2025

Conflicts in testProfileVectorSearchMode due to differences in profile output format


Note

Add vector search mode (incl. RANGE_QUERY and HYBRID variants) and largest-batch stats to FT.PROFILE; track these in HybridIterator and update tests.

  • Profiling (FT.PROFILE):
    • Add Vector search mode for VECTOR and METRIC - VECTOR DISTANCE iterators.
    • In hybrid batches modes, print Batches number, Largest batch size, and Largest batch iteration.
  • Hybrid iterator (src/hybrid_reader.*):
    • Track maxBatchSize and maxBatchIteration; initialize/reset on create/rewind and update during batch sizing.
  • VecSim utilities (src/vector_index.*):
    • Add VecSimSearchMode_ToString and use it in profile output.
  • Profile printing (src/index.c, src/profile.h):
    • Print vector search mode and batch stats in iterator profiles, including for range queries.
  • Tests (tests/pytests/test_profile.py):
    • Update expected profile outputs and add coverage for vector search modes across SEARCH/AGGREGATE.

Written by Cursor Bugbot for commit 5c7ff64. This will update automatically on new commits. Configure here.

meiravgri and others added 3 commits November 20, 2025 13:54
…ails (#7436)

fix test due to differences in profile output format

align agg and search "shards" entry
@meiravgri meiravgri requested a review from alonre24 November 20, 2025 14:00
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.26%. Comparing base (80e92e4) to head (5c7ff64).
⚠️ Report is 2 commits behind head on 2.10.

Files with missing lines Patch % Lines
src/vector_index.c 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #7448      +/-   ##
==========================================
- Coverage   89.29%   89.26%   -0.04%     
==========================================
  Files         207      207              
  Lines       35309    35337      +28     
==========================================
+ Hits        31530    31542      +12     
- Misses       3779     3795      +16     
Flag Coverage Δ
flow 83.84% <89.28%> (-0.16%) ⬇️
unit 42.45% <28.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Nov 20, 2025
Merged via the queue into 2.10 with commit be84540 Nov 20, 2025
14 checks passed
@meiravgri meiravgri deleted the backport-7436-to-2.10 branch November 20, 2025 15:56
@redisearch-backport-pull-request
Copy link
Contributor

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-7448-to-2.8 origin/2.8
cd .worktree/backport-7448-to-2.8
git switch --create backport-7448-to-2.8
git cherry-pick -x be8454085c7f62d826c75f09d552d1a35774a581

meiravgri added a commit that referenced this pull request Nov 20, 2025
…tails (#7436) (#7448)

* [8.2] [MOD-12263] Enhance FT.PROFILE with vector search execution details (#7436)

fix test due to differences in profile output format

align agg and search "shards" entry

* revert align shard and Shards (search and agg)

* handke in test

* fix

(cherry picked from commit be84540)
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2025
…ails (#7436) (#7448) (#7451)

[2.10] [MOD-12263] Enhance FT.PROFILE with vector search execution details (#7436) (#7448)

* [8.2] [MOD-12263] Enhance FT.PROFILE with vector search execution details (#7436)

fix test due to differences in profile output format

align agg and search "shards" entry

* revert align shard and Shards (search and agg)

* handke in test

* fix

(cherry picked from commit be84540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants