Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7441 +/- ##
==========================================
+ Coverage 84.80% 84.87% +0.07%
==========================================
Files 346 347 +1
Lines 53426 53675 +249
Branches 14042 14292 +250
==========================================
+ Hits 45307 45559 +252
+ Misses 7923 7920 -3
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Nov 20, 2025
Collaborator
alonre24
left a comment
alonre24
left a comment
There was a problem hiding this comment.
Can we add your micro benchmark to this PR?
alonre24
approved these changes
Nov 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7441-to-8.2 origin/8.2
cd .worktree/backport-7441-to-8.2
git switch --create backport-7441-to-8.2
git cherry-pick -x a904cf5a1c5cc1d0b6e6d220ea853d45006c5c9d |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
send heartbeat once, and make the parent wait for it (cherry picked from commit a904cf5)
Contributor
|
Successfully created backport PR for |
GuyAv46
added a commit
that referenced
this pull request
Nov 21, 2025
send heartbeat once, and make the parent wait for it (cherry picked from commit a904cf5)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
Fix GC regression - [MOD-12538] (#7441) send heartbeat once, and make the parent wait for it (cherry picked from commit a904cf5) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
We added
RedisModule_SendChildHeartbeatcalls #5503, after every inverted index scanned (even if it wasn't changed).This was recently proved to slow the process down significantly - sub-second tasks take minutes to complete.
The goal was to get a print for the CoW info before we exit, so as we expect GC runs to be short, we will now call the heartbeat API once, right before finishing.
We add another terminal marker to the protocol, so the parent will wait until this info is logged before attempting to kill the child.
Mark if applicable
Note
Consolidates ForkGC child heartbeats to a single final heartbeat and adds a terminal marker so the parent waits before termination, removing progress tracking.
RedisModule_SendChildHeartbeat(1.0)after all scans complete.FGC_sendTerminatorto mark post-processing completion.SIZE_MAX) before finishing, ensuring the heartbeat is logged.ForkGC.progressfield.Written by Cursor Bugbot for commit 42b8090. This will update automatically on new commits. Configure here.