[8.4] [MOD-12416] Create basis for tracking Query Errors and track syntax and args errors#7422
Merged
[8.4] [MOD-12416] Create basis for tracking Query Errors and track syntax and args errors#7422
Conversation
…nd args errors (#7386) * Query error metric with coord base * remove coord - not used yet * Count syntax and arg errors * Revert "remove coord - not used yet" This reverts commit 8cff9f0. * Seperate into shard error and coord error * tests * Treat SA as shard * Meirav fixups (cherry picked from commit 4c31dc3) * Add future test * fix hybrid SA test * Refractor previous dict check (cherry picked from commit bf41b7f)
lerman25
previously approved these changes
Nov 19, 2025
meiravgri
approved these changes
Nov 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7422 +/- ##
==========================================
- Coverage 85.71% 85.69% -0.03%
==========================================
Files 330 330
Lines 52324 52375 +51
Branches 12001 12001
==========================================
+ Hits 44850 44881 +31
- Misses 7306 7327 +21
+ Partials 168 167 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
Collaborator
|
/backport |
Contributor
Author
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7422-to-8.2 origin/8.2
cd .worktree/backport-7422-to-8.2
git switch --create backport-7422-to-8.2
git cherry-pick -x 958b361555597bd082924ec5f78734b14674e9aa |
lerman25
added a commit
that referenced
this pull request
Nov 30, 2025
…and args errors ([#7422](#7422)) * [MOD-12416] Create basis for tracking Query Errors and track syntax and args errors ([#7386](#7386)) * Query error metric with coord base * remove coord - not used yet * Count syntax and arg errors * Revert "remove coord - not used yet" This reverts commit 8cff9f0. * Seperate into shard error and coord error * tests * Treat SA as shard * Meirav fixups (cherry picked from commit 4c31dc3) * Add future test * fix hybrid SA test * Refractor previous dict check (cherry picked from commit bf41b7f) * Replace to c enum --------- Co-authored-by: lerman25 <[email protected]> Co-authored-by: lerman25 <[email protected]> (cherry picked from commit 958b361)
lerman25
added a commit
that referenced
this pull request
Nov 30, 2025
…and args errors ([[#7422](https://github.com/RediSearch/RediSearch/issues/7422)](https://github.com/RediSearch/RediSearch/issues/7422)) * [MOD-12416] Create basis for tracking Query Errors and track syntax and args errors ([[#7386](https://github.com/RediSearch/RediSearch/issues/7386)](https://github.com/RediSearch/RediSearch/issues/7386)) * Query error metric with coord base * remove coord - not used yet * Count syntax and arg errors * Revert "remove coord - not used yet" This reverts commit 8cff9f0. * Seperate into shard error and coord error * tests * Treat SA as shard * Meirav fixups (cherry picked from commit 4c31dc3) * Add future test * fix hybrid SA test * Refractor previous dict check (cherry picked from commit bf41b7f) * Replace to c enum --------- Co-authored-by: lerman25 <[email protected]> Co-authored-by: lerman25 <[email protected]> (cherry picked from commit 958b361)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2025
…ntax … (#7577) [MOD-12416] Create basis for tracking Query Errors and track syntax and args errors ([[#7422](https://github.com/RediSearch/RediSearch/issues/7422)](https://github.com/RediSearch/RediSearch/issues/7422)) * [MOD-12416] Create basis for tracking Query Errors and track syntax and args errors ([[#7386](https://github.com/RediSearch/RediSearch/issues/7386)](https://github.com/RediSearch/RediSearch/issues/7386)) * Query error metric with coord base * remove coord - not used yet * Count syntax and arg errors * Revert "remove coord - not used yet" This reverts commit 8cff9f0. * Seperate into shard error and coord error * tests * Treat SA as shard * Meirav fixups (cherry picked from commit 4c31dc3) * Add future test * fix hybrid SA test * Refractor previous dict check (cherry picked from commit bf41b7f) * Replace to c enum --------- (cherry picked from commit 958b361)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7386 to
8.4.Note
Add global counters for query syntax/argument errors (shard vs coordinator), instrument error paths in search/aggregate/hybrid flows, and expose them in INFO MODULES with tests.
QueryErrorsGlobalStatsandQueryErrorsGlobalStats_UpdateError(...)withCOORD_ERR_WARN/SHARD_ERR_WARNto track query errors by type (syntax,arguments) and origin (coordinator vs shard).TotalGlobalStats_GetQueryStats()to return new error counters.aggregate/aggregate_exec.c(execCommandCommon),coord/dist_aggregate.c(DistAggregateCleanups),coord/hybrid/dist_hybrid.c(DistHybridCleanups),hybrid/hybrid_exec.c(CleanupAndReplyStatus), andmodule.c(bailOut).info_redis.c, add new metrics underwarnings_and_errorsandcoordinator_warnings_and_errors:shard_total_query_errors_syntax/argumentsandcoord_total_query_errors_syntax/arguments.FT.SEARCH,FT.AGGREGATE, andFT.HYBRID, including no-error queries not affecting counters.Written by Cursor Bugbot for commit d4db2e9. This will update automatically on new commits. Configure here.