Skip to content

[2.10] [MOD-6056] Rename FT.PROFILE counter fields (#7341)#7381

Merged
meiravgri merged 1 commit into2.10from
backport-7303-to-2.10
Nov 17, 2025
Merged

[2.10] [MOD-6056] Rename FT.PROFILE counter fields (#7341)#7381
meiravgri merged 1 commit into2.10from
backport-7303-to-2.10

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Nov 17, 2025

backport of #7303 to 2.10


Note

Renames FT.PROFILE output fields (counters and sizes) for clarity and updates core printing logic and tests accordingly.

  • Profile output changes (core):
    • Replace iterator Counter with Number of reading operations across src/index.c printer functions and src/profile.c.
    • Replace result processor Counter with Results processed via printProfileRPCounter.
    • Rename Size to Estimated number of matches in printReadIt for readers.
    • Introduce macros in src/profile.h: printProfileIteratorCounter and printProfileRPCounter; update all call sites (e.g., printUnionIt, printIntersectIt, printMetricIt, child printers).
  • Tests:
    • Update expectations throughout pytest suite to the new field names in FT.PROFILE outputs (iterators, result processors, numeric/geo/tag/vector cases, RESP3 profiles, timeout warnings, etc.).

Written by Cursor Bugbot for commit 25bfc30. This will update automatically on new commits. Configure here.

* [MOD-6056] Rename `FT.PROFILE` counter fields (#7303)

rename profile counters fields
iterators `Size` -> `Estimated number of matches`
iterators `Counter` -> `Number of reading operations`
RP `Counter` -> 'Results processed'

(cherry picked from commit 508087c)

* fix

(cherry picked from commit c65cc38)
@meiravgri meiravgri requested a review from alonre24 November 17, 2025 05:41
@meiravgri meiravgri enabled auto-merge November 17, 2025 05:43
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.25%. Comparing base (0c2fed5) to head (25bfc30).
⚠️ Report is 1 commits behind head on 2.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #7381      +/-   ##
==========================================
- Coverage   89.27%   89.25%   -0.02%     
==========================================
  Files         207      207              
  Lines       35307    35307              
==========================================
- Hits        31522    31515       -7     
- Misses       3785     3792       +7     
Flag Coverage Δ
flow 83.83% <100.00%> (-0.16%) ⬇️
unit 42.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Nov 17, 2025
Merged via the queue into 2.10 with commit 7451330 Nov 17, 2025
13 checks passed
@meiravgri meiravgri deleted the backport-7303-to-2.10 branch November 17, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants