Skip to content

[2.8] [MOD-6056] Rename FT.PROFILE counter fields (#7303)#7380

Merged
meiravgri merged 4 commits into2.8from
backport-7303-to-2.8
Nov 17, 2025
Merged

[2.8] [MOD-6056] Rename FT.PROFILE counter fields (#7303)#7380
meiravgri merged 4 commits into2.8from
backport-7303-to-2.8

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Nov 17, 2025

backport #7303 to 2.8


Note

Renames FT.PROFILE counters to clearer labels across code and tests, splitting iterator vs result-processor counts and updating related output keys.

  • Profile output changes
    • Replace Counter with Number of reading operations for iterators and Results processed for result processors.
    • Rename Size to Estimated number of matches in iterator outputs.
    • Introduce macros printProfileIteratorCounter and printProfileRPCounter; update calls in src/index.c and src/profile.c.
  • Code updates
    • Adjust iterator/profile printers (printUnionIt, printIntersectIt, metric/profile printers) to use new labels.
    • Update recursive RP profiling to use printProfileRPCounter.
  • Tests
    • Update all FT.PROFILE expectations (RESP2/RESP3) to new field names and texts across geo, optimizer, profile, resp3, and issues tests.

Written by Cursor Bugbot for commit 9690654. This will update automatically on new commits. Configure here.

rename profile counters fields
iterators `Size` -> `Estimated number of matches`
iterators `Counter` -> `Number of reading operations`
RP `Counter` -> 'Results processed'

(cherry picked from commit 508087c)
@meiravgri meiravgri requested a review from alonre24 November 17, 2025 05:25
@meiravgri meiravgri changed the title [MOD-6056] Rename FT.PROFILE counter fields (#7303) [2.8] [MOD-6056] Rename FT.PROFILE counter fields (#7303) Nov 17, 2025
@meiravgri meiravgri enabled auto-merge November 17, 2025 05:43
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.44%. Comparing base (d06815f) to head (9690654).
⚠️ Report is 1 commits behind head on 2.8.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #7380      +/-   ##
==========================================
- Coverage   87.45%   87.44%   -0.01%     
==========================================
  Files         203      203              
  Lines       34782    34782              
==========================================
- Hits        30418    30416       -2     
- Misses       4364     4366       +2     
Flag Coverage Δ
flow 81.82% <100.00%> (-0.22%) ⬇️
unit 42.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Nov 17, 2025
Merged via the queue into 2.8 with commit e0f767e Nov 17, 2025
13 checks passed
@meiravgri meiravgri deleted the backport-7303-to-2.8 branch November 17, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants