[2.10] MOD-12212: Fix index load from RDB temporary memory overhead#7360
Merged
Itzikvaknin merged 2 commits into2.10from Nov 16, 2025
Merged
[2.10] MOD-12212: Fix index load from RDB temporary memory overhead#7360Itzikvaknin merged 2 commits into2.10from
Itzikvaknin merged 2 commits into2.10from
Conversation
Itzikvaknin
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7360 +/- ##
==========================================
- Coverage 89.27% 89.24% -0.04%
==========================================
Files 207 207
Lines 35307 35307
==========================================
- Hits 31521 31508 -13
- Misses 3786 3799 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dor-forer
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test: https://github.com/redislabsdev/Redis-Enterprise/actions/runs/19330696319/job/55292760560
Note
Defers GC startup until after duplicate detection during RDB index load and tightens synonym map load error flow.
src/spec.c):IndexSpec_StartGCto after duplicate-spec check; start GC only for non-duplicates.Cursors_initSpec(sp)before optional synonym map loading.SynonymMap_RdbLoadfailure unconditionally jumps tocleanup.specDict_gand update field stats only after starting GC for valid (non-duplicate) specs.Written by Cursor Bugbot for commit 6f76f36. This will update automatically on new commits. Configure here.