Skip to content

[8.4] [RED-176382] Fix FT.CREATE failure with LeanVec parameters on non-Intel architectures#7346

Merged
alonre24 merged 3 commits into8.4from
meiravg_fix_lvq_check_8.4
Nov 12, 2025
Merged

[8.4] [RED-176382] Fix FT.CREATE failure with LeanVec parameters on non-Intel architectures#7346
alonre24 merged 3 commits into8.4from
meiravg_fix_lvq_check_8.4

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Nov 12, 2025

pr #7344 to 8.4


Note

Makes LVQ support queryable, decouples LeanVec type checks from platform, gates FT.INFO reduced_dim on LVQ support, and updates SVS tests to include LeanVec4x8 with REDUCE.

  • VecSim core:
    • Make isLVQSupported() public (remove static and declare in src/vector_index.h).
    • Update VecSim_IsLeanVecCompressionType to only check quantBits (no platform gating).
    • Keep runtime compression string resolution platform-aware via isLVQSupported().
  • FT.INFO reporting:
    • Report reduced_dim only when isLVQSupported() and VecSim_IsLeanVecCompressionType are true.
  • Tests (SVS-VAMANA):
    • Include LeanVec4x8 in compression types for info tests; add REDUCE when using LeanVec4x8.
    • Expect reduced_dim in info output when runtime compression is LeanVec4x8/LeanVec8x8.

Written by Cursor Bugbot for commit e08a961. This will update automatically on new commits. Configure here.

@meiravgri meiravgri changed the title pr #7344 to 8.4 RED-176382 Nov 12, 2025
@meiravgri meiravgri requested a review from alonre24 November 12, 2025 16:58
@meiravgri meiravgri changed the title RED-176382 [8.4] [RED-176382] Fix FT.CREATE failure with LeanVec parameters on non-Intel architectures Nov 12, 2025
@meiravgri meiravgri enabled auto-merge November 12, 2025 17:09
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (e232241) to head (e08a961).
⚠️ Report is 2 commits behind head on 8.4.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.4    #7346      +/-   ##
==========================================
- Coverage   85.70%   85.69%   -0.02%     
==========================================
  Files         330      330              
  Lines       52297    52297              
  Branches    12001    12001              
==========================================
- Hits        44823    44815       -8     
- Misses       7307     7315       +8     
  Partials      167      167              
Flag Coverage Δ
flow 84.22% <100.00%> (-0.13%) ⬇️
unit 52.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Nov 12, 2025
@alonre24 alonre24 removed this pull request from the merge queue due to a manual request Nov 12, 2025
@alonre24 alonre24 added this pull request to the merge queue Nov 12, 2025
@alonre24 alonre24 removed this pull request from the merge queue due to a manual request Nov 12, 2025
@alonre24 alonre24 added this pull request to the merge queue Nov 12, 2025
Merged via the queue into 8.4 with commit 4b9dceb Nov 12, 2025
19 checks passed
@alonre24 alonre24 deleted the meiravg_fix_lvq_check_8.4 branch November 12, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants