RED-176382 Fix FT.CREATE failure with LeanVec parameters on non-Intel architectures#7344
Merged
RED-176382 Fix FT.CREATE failure with LeanVec parameters on non-Intel architectures#7344
Conversation
remove isLVQSupportedfrom VecSim_IsLeanVecCompressionType expose isLVQSupported add , 'LeanVec4x8' to test_vecsim_svs:test_svs_vamana_info
alonre24
reviewed
Nov 12, 2025
alonre24
approved these changes
Nov 12, 2025
meiravgri
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7344 +/- ##
==========================================
- Coverage 85.26% 85.25% -0.02%
==========================================
Files 344 344
Lines 53005 53005
Branches 13712 13712
==========================================
- Hits 45194 45187 -7
- Misses 7616 7623 +7
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auto-merge was automatically disabled
November 12, 2025 17:41
Pull Request is not mergeable
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
…-Intel architectures (#7350) RED-176382 Fix FT.CREATE failure with LeanVec parameters on non-Intel architectures (#7344) * move isLVQSupported() to info remove isLVQSupportedfrom VecSim_IsLeanVecCompressionType expose isLVQSupported add , 'LeanVec4x8' to test_vecsim_svs:test_svs_vamana_info * add reduce (cherry picked from commit 2c35686) Co-authored-by: meiravgri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VecSim_IsLeanVecCompressionType()was checking both the compression type AND Intel architecture support, causingFT.CREATEcommands with validLeanVecparameters to fail on non-Intel systems during parameter validation.Solution
VecSim_IsLeanVecCompressionType()to only check if the compression type is LeanVec (removed Intel CPU check)isLVQSupported()function to check Intel architecture support separatelyFT.INFOwhen displayingreduced_dimfield