Skip to content

[8.4] [MOD-6056] Rename FT.PROFILE counter fields#7319

Merged
meiravgri merged 1 commit into8.4from
backport-7303-to-8.4
Nov 12, 2025
Merged

[8.4] [MOD-6056] Rename FT.PROFILE counter fields#7319
meiravgri merged 1 commit into8.4from
backport-7303-to-8.4

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Nov 12, 2025

Description

Backport of #7303 to 8.4.


Note

Renames FT.PROFILE fields (Counter → iterator/processor-specific labels; SizeEstimated number of matches) and updates code/tests accordingly.

  • Profile output (FT.PROFILE):
    • Rename Counter to Number of reading operations (iterators) and Results processed (result processors).
    • Rename Size to Estimated number of matches.
  • Implementation:
    • Update macros in src/profile.h and calls in src/profile.c (e.g., use printProfileRPCounter, add estimated matches in iterator replies).
  • Tests:
    • Update expected profile fields across geo, issues, optimizer, profile, RESP3, and shard window ratio tests to new names.

Written by Cursor Bugbot for commit 1b2224a. This will update automatically on new commits. Configure here.

rename profile counters fields
iterators `Size` -> `Estimated number of matches`
iterators `Counter` -> `Number of reading operations`
RP `Counter` -> 'Results processed'

(cherry picked from commit 508087c)
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (45b9ea3) to head (1b2224a).
⚠️ Report is 8 commits behind head on 8.4.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.4    #7319      +/-   ##
==========================================
- Coverage   85.71%   85.68%   -0.04%     
==========================================
  Files         330      330              
  Lines       52297    52297              
  Branches    12001    12001              
==========================================
- Hits        44826    44810      -16     
- Misses       7304     7320      +16     
  Partials      167      167              
Flag Coverage Δ
flow 84.22% <100.00%> (-0.15%) ⬇️
unit 52.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Nov 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@meiravgri meiravgri added this pull request to the merge queue Nov 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@meiravgri meiravgri added this pull request to the merge queue Nov 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@meiravgri meiravgri added this pull request to the merge queue Nov 12, 2025
Merged via the queue into 8.4 with commit e232241 Nov 12, 2025
22 checks passed
@meiravgri meiravgri deleted the backport-7303-to-8.4 branch November 12, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant