[MOD-6056] Rename FT.PROFILE counter fields#7303
Merged
Conversation
iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed'
meiravgri
changed the title
FT.PROFILE counters fields
meiravgri
changed the title
FT.PROFILE counters fieldsFT.PROFILE counter fields
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7303 +/- ##
==========================================
+ Coverage 85.04% 85.10% +0.06%
==========================================
Files 341 343 +2
Lines 51670 52912 +1242
Branches 12526 13803 +1277
==========================================
+ Hits 43941 45029 +1088
- Misses 7537 7688 +151
- Partials 192 195 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Nov 11, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7303-to-8.2 origin/8.2
cd .worktree/backport-7303-to-8.2
git switch --create backport-7303-to-8.2
git cherry-pick -x 508087c62127c7cedb60cff55a4635e58dc76952 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c)
Contributor
|
Successfully created backport PR for |
meiravgri
added a commit
that referenced
this pull request
Nov 12, 2025
rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
[MOD-6056] Rename `FT.PROFILE` counter fields (#7303) rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c) Co-authored-by: meiravgri <[email protected]>
Collaborator
Author
|
/backport |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-7303-to-2.8 origin/2.8
cd .worktree/backport-7303-to-2.8
git switch --create backport-7303-to-2.8
git cherry-pick -x 508087c62127c7cedb60cff55a4635e58dc76952 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-7303-to-2.10 origin/2.10
cd .worktree/backport-7303-to-2.10
git switch --create backport-7303-to-2.10
git cherry-pick -x 508087c62127c7cedb60cff55a4635e58dc76952 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7303-to-8.2 origin/8.2
cd .worktree/backport-7303-to-8.2
git switch --create backport-7303-to-8.2
git cherry-pick -x 508087c62127c7cedb60cff55a4635e58dc76952 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.4
git worktree add -d .worktree/backport-7303-to-8.4 origin/8.4
cd .worktree/backport-7303-to-8.4
git switch --create backport-7303-to-8.4
git cherry-pick -x 508087c62127c7cedb60cff55a4635e58dc76952 |
meiravgri
added a commit
that referenced
this pull request
Nov 17, 2025
rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c)
meiravgri
added a commit
that referenced
this pull request
Nov 17, 2025
* [MOD-6056] Rename `FT.PROFILE` counter fields (#7303) rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c) * fix (cherry picked from commit c65cc38)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
* [MOD-6056] Rename `FT.PROFILE` counter fields (#7303) rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c) * fix * fix test_issues * fix test_resp3
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
[8.2] [MOD-6056] Rename `FT.PROFILE` counter fields (#7341) * [MOD-6056] Rename `FT.PROFILE` counter fields (#7303) rename profile counters fields iterators `Size` -> `Estimated number of matches` iterators `Counter` -> `Number of reading operations` RP `Counter` -> 'Results processed' (cherry picked from commit 508087c) * fix (cherry picked from commit c65cc38)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename FT.PROFILE fields for clarity
Iterator fields:
Counter→Number of reading operations- counts read/skipTo operations performed by the iteratorSize→Estimated number of matches- upper-bound estimate of results the iterator will yieldResult Processor fields:
Counter→Results processed- counts how many results passed through the processor