Skip to content

[2.8] [RED-169833] fix: fix reporting used memory as unsigned long long (#6…#7278

Merged
JoanFM merged 1 commit into2.8from
backport-6971-to-2.8
Nov 11, 2025
Merged

[2.8] [RED-169833] fix: fix reporting used memory as unsigned long long (#6…#7278
JoanFM merged 1 commit into2.8from
backport-6971-to-2.8

Conversation

@JoanFM
Copy link
Collaborator

@JoanFM JoanFM commented Nov 10, 2025

…971)

  • fix: fix reporting used memory as unsigned long long

  • change the bytes collected type to double again after change by other PR

(cherry picked from commit ca5b662)

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Use unsigned long long for memory, GC, and error metrics in INFO output instead of doubles, keeping human-readable fields unchanged.

  • INFO reporting updates (src/info/info_redis.c):
    • Memory section: used_memory_indexes, smallest_memory_index, largest_memory_index, used_memory_vector_index now use RedisModule_InfoAddFieldULongLong; human-readable *_human remain doubles.
    • GC section: bytes_collected, total_cycles, total_ms_run switched to RedisModule_InfoAddFieldULongLong.
    • Warnings and errors: errors_indexing_failures, errors_for_index_with_max_failures, OOM_indexing_failures_indexes_count switched to RedisModule_InfoAddFieldULongLong.

Written by Cursor Bugbot for commit f1c1687. This will update automatically on new commits. Configure here.

)

* fix: fix reporting used memory as unsigned long long

* change the bytes collected type to double again after change by other PR

(cherry picked from commit ca5b662)
@JoanFM JoanFM requested a review from oshadmi November 10, 2025 10:35
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.44%. Comparing base (cb44922) to head (f1c1687).
⚠️ Report is 2 commits behind head on 2.8.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #7278      +/-   ##
==========================================
- Coverage   87.49%   87.44%   -0.06%     
==========================================
  Files         203      203              
  Lines       34784    34784              
==========================================
- Hits        30435    30417      -18     
- Misses       4349     4367      +18     
Flag Coverage Δ
flow 81.81% <100.00%> (-0.27%) ⬇️
unit 42.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoanFM JoanFM self-assigned this Nov 10, 2025
@JoanFM JoanFM enabled auto-merge November 10, 2025 14:58
@JoanFM JoanFM added this pull request to the merge queue Nov 11, 2025
Merged via the queue into 2.8 with commit 654f454 Nov 11, 2025
13 checks passed
@JoanFM JoanFM deleted the backport-6971-to-2.8 branch November 11, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants