[2.10] [MOD-12243] fix: fix concurrency issue on Reducer#7218
Merged
redisearch-backport-pull-request[bot] merged 1 commit into2.10from Nov 4, 2025
Merged
[2.10] [MOD-12243] fix: fix concurrency issue on Reducer#7218redisearch-backport-pull-request[bot] merged 1 commit into2.10from
redisearch-backport-pull-request[bot] merged 1 commit into2.10from
Conversation
* fix: fix concurrency issue on Reducer * test: fix test distagg * fix: make it static array * fix: fix proper static * Update src/module-init/module-init.c * Update src/aggregate/reducer.c Co-authored-by: GuyAv46 <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 7184778)
JoanFM
approved these changes
Nov 4, 2025
redisearch-backport-pull-request
bot
deleted the
backport-7214-to-2.10
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7218 +/- ##
==========================================
- Coverage 89.28% 89.25% -0.03%
==========================================
Files 207 207
Lines 35318 35308 -10
==========================================
- Hits 31532 31513 -19
- Misses 3786 3795 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoanFM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7214 to
2.10.Note
Replace dynamic reducer registration with a fixed static registry and remove registration code, simplifying
RDCR_GetFactory.src/aggregate/reducer.c(globalRegistrywith 14 entries) and validate size viastatic_assert.RDCR_GetFactoryto iterate over the fixed registry; remove lazy init and dynamic array usage.RDCR_RegisterFactory/RDCR_RegisterBuiltinsimplementations and their declarations fromsrc/aggregate/reducer.h.Written by Cursor Bugbot for commit f3a8f3c. This will update automatically on new commits. Configure here.