[2.10] MOD-11090: Try marking DROP commands as touches-arbitrary-keys (#6795)#7167
Merged
[2.10] MOD-11090: Try marking DROP commands as touches-arbitrary-keys (#6795)#7167
Conversation
(cherry picked from commit 3bf233f)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7167 +/- ##
==========================================
- Coverage 89.26% 89.22% -0.04%
==========================================
Files 207 207
Lines 35267 35281 +14
==========================================
Hits 31481 31481
- Misses 3786 3800 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oshadmi
approved these changes
Oct 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6795 to
2.10.(cherry picked from commit 3bf233f)
Note
Registers DROP commands with the touches-arbitrary-keys flag via a new helper that falls back to original flags if unsupported.
RMCreateArbitraryWriteSearchCommandto attempttouches-arbitrary-keysflag with fallback to original flags.RS_DROP_CMD,RS_DROP_INDEX_CMD,RS_DROP_IF_X_CMD, andRS_DROP_INDEX_IF_X_CMDas arbitrary-key writes.RS_INFO_CMDand other commands unchanged aside from ordering.Written by Cursor Bugbot for commit 8a1fe11. This will update automatically on new commits. Configure here.