Skip to content

[8.2] MOD-11090: Try marking DROP commands as touches-arbitrary-keys (#6795)#7165

Merged
oshadmi merged 1 commit into8.2from
nafraf_backport-6795-to-8.2
Oct 28, 2025
Merged

[8.2] MOD-11090: Try marking DROP commands as touches-arbitrary-keys (#6795)#7165
oshadmi merged 1 commit into8.2from
nafraf_backport-6795-to-8.2

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented Oct 27, 2025

Description

Backport of #6795 to 8.2.
(cherry picked from commit 3bf233f)


Note

Adds a helper to register DROP commands with the touches-arbitrary-keys flag, falling back to original flags if unsupported.

  • Command registration:
    • Add RMCreateArbitraryWriteSearchCommand to try touches-arbitrary-keys and fallback to original flags.
    • Use the helper for DROP-related commands:
      • RS_DROP_CMDDropIndexCommand
      • RS_DROP_INDEX_CMDDropIndexCommand
      • RS_DROP_IF_X_CMDDropIfExistsIndexCommand
      • RS_DROP_INDEX_IF_X_CMDDropIfExistsIndexCommand

Written by Cursor Bugbot for commit 6ff0803. This will update automatically on new commits. Configure here.

@nafraf nafraf changed the title MOD-11090: Try marking DROP commands as touches-arbitrary-keys (#6795) [8.2] MOD-11090: Try marking DROP commands as touches-arbitrary-keys (#6795) Oct 27, 2025
@nafraf nafraf marked this pull request as ready for review October 27, 2025 18:07
@nafraf nafraf requested a review from oshadmi October 27, 2025 18:20
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (d9d765f) to head (6ff0803).
⚠️ Report is 1 commits behind head on 8.2.

Files with missing lines Patch % Lines
src/module.c 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.2    #7165      +/-   ##
==========================================
- Coverage   89.39%   89.37%   -0.03%     
==========================================
  Files         253      253              
  Lines       40725    40739      +14     
  Branches     3725     3725              
==========================================
+ Hits        36408    36411       +3     
- Misses       4268     4279      +11     
  Partials       49       49              
Flag Coverage Δ
flow 82.03% <94.44%> (-0.14%) ⬇️
unit 47.41% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oshadmi oshadmi added this pull request to the merge queue Oct 28, 2025
Merged via the queue into 8.2 with commit 2ff4554 Oct 28, 2025
24 of 27 checks passed
@oshadmi oshadmi deleted the nafraf_backport-6795-to-8.2 branch October 28, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants