[2.8] [MOD-11817] FT.AGGREGATE show Background Indexing OOM warning#7157
Merged
[2.8] [MOD-11817] FT.AGGREGATE show Background Indexing OOM warning#7157
Conversation
alonre24
previously approved these changes
Oct 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7157 +/- ##
==========================================
- Coverage 87.49% 87.43% -0.06%
==========================================
Files 203 203
Lines 35636 34753 -883
==========================================
- Hits 31181 30388 -793
+ Misses 4455 4365 -90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Oct 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…7157) * [MOD-11817] FT.AGGREGATE show Background Indexing OOM warning (#7141) * Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment (cherry picked from commit 49a986c) (cherry picked from commit 3129614) (cherry picked from commit 95d3916) * fix tests
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #7141 to 2.8
Note
FT.AGGREGATE now returns a RESP3 warning for background indexing OOM, propagated from shards/coordinator; adds iterator flag and updates tests accordingly.
QUERY_WINDEXING_FAILUREin RESP3 shard replies and setreq->qiter.bgScanOOMincoord/src/dist_aggregate.c.src/aggregate/aggregate_exec.c(RESP3), includeQUERY_WINDEXING_FAILUREinwarningwhenreq->qiter.bgScanOOMorspec->scan_failed_OOMis set, ensuring FT.AGGREGATE surfaces the partial-results OOM warning.bool bgScanOOMtoQueryIterator(src/result_processor.h).FT.AGGREGATEand cluster cases; centralize module info key asinfo_modules_oom_count_str.tests/pytests/common.pyto avoid hanging loops.Written by Cursor Bugbot for commit 7d4c95a. This will update automatically on new commits. Configure here.