[MOD-11817] FT.AGGREGATE show Background Indexing OOM warning#7141
Merged
[MOD-11817] FT.AGGREGATE show Background Indexing OOM warning#7141
Conversation
Bug: Cluster Decorator Conflicts with Test EnvironmentThe Additional Locations (1) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7141 +/- ##
==========================================
- Coverage 85.58% 85.56% -0.03%
==========================================
Files 327 327
Lines 51985 51987 +2
Branches 11133 11133
==========================================
- Hits 44492 44481 -11
- Misses 7325 7338 +13
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Oct 26, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-7141-to-2.8 origin/2.8
cd .worktree/backport-7141-to-2.8
git switch --create backport-7141-to-2.8
git cherry-pick -x 49a986ce7d3baadfae8c0dc7d15bb3afdf20dca1 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-7141-to-2.10 origin/2.10
cd .worktree/backport-7141-to-2.10
git switch --create backport-7141-to-2.10
git cherry-pick -x 49a986ce7d3baadfae8c0dc7d15bb3afdf20dca1 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7141-to-8.2 origin/8.2
cd .worktree/backport-7141-to-8.2
git switch --create backport-7141-to-8.2
git cherry-pick -x 49a986ce7d3baadfae8c0dc7d15bb3afdf20dca1 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
* Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment (cherry picked from commit 49a986c)
Contributor
|
Successfully created backport PR for |
lerman25
added a commit
that referenced
this pull request
Oct 26, 2025
* Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment (cherry picked from commit 49a986c)
lerman25
added a commit
that referenced
this pull request
Oct 27, 2025
* Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment (cherry picked from commit 49a986c)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…7153) [MOD-11817] FT.AGGREGATE show Background Indexing OOM warning (#7141) * Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment (cherry picked from commit 49a986c) Co-authored-by: lerman25 <[email protected]>
chesedo
pushed a commit
that referenced
this pull request
Oct 27, 2025
* Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…7157) * [MOD-11817] FT.AGGREGATE show Background Indexing OOM warning (#7141) * Check aggregate in verbosity test * check verbosity in tests * Check bg scan warning and raise accordingly * Refractor tests * Add comment * fix comment (cherry picked from commit 49a986c) (cherry picked from commit 3129614) (cherry picked from commit 95d3916) * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Background indexing OOM warning doesn't propagate properly in
FT.AGGREGATEin RESP3.This PR fixes this by adding the missing check in
rpnetNext.This PR also does slight refactoring in test_index_oom.py file and related functions in common.py.
Note
Propagates background-indexing OOM warnings from shards to coordinator and surfaces them in RESP3 FT.AGGREGATE, with tests and utility timeouts.
QUERY_WINDEXING_FAILUREinwarningwhen eitherqctx->bgScanOOMorsctx->spec->scan_failed_OOM.warningand setAREQ_QueryProcessingCtx(...)->bgScanOOM = trueonQUERY_WINDEXING_FAILURE.bool bgScanOOMtoQueryProcessingCtx.warningassertions forFT.AGGREGATE(and extend SEARCH/PROFILE checks).info_modules_oom_count_strand adjust env setup for certain tests.common.py(waitForIndex*helpers) to prevent infinite loops.Written by Cursor Bugbot for commit 58cb344. This will update automatically on new commits. Configure here.