[MOD-12005] Add slot ranges comparison logic#7130
Merged
Conversation
JoanFM
force-pushed
the
joan-slots-comparison
branch
from
475bd20 to
f0c8181
Compare
JoanFM
force-pushed
the
joan-slots-comparison
branch
from
871332c to
eeaca26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7130 +/- ##
==========================================
+ Coverage 85.59% 85.65% +0.06%
==========================================
Files 328 328
Lines 51001 51020 +19
Branches 11016 11016
==========================================
+ Hits 43652 43700 +48
+ Misses 7179 7151 -28
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Oct 28, 2025
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
* initial registration implementation * Set up most of the notification events * address review comment and add logs * implement propagation * minor improvements * small fix * review fixes * [TEMP] set CI for new API * dictionary tidy up * add first test * fix helper and test for duplicates * Add missing sub-command * add unit-tests for coverage * change workersThreadPool_OnEvent* behavior to handle overlapping events * rename events after API update * implement managed and thread-safe slot ranges API * drop cached API when needed * rename API and use in the pipeline * move includes to C file * skip current flow test, and introduce a stable one * fix initial reference count * implement mock and add a test * add missing key-space notification subscription * add a test with adding a new node and propagating the schema * review fixes * fix assertion * leak fix * use malloc * leak actual fix * don't drop the cache on failed events * add BG variants to flow tests * initial registration implementation * Set up most of the notification events * address review comment and add logs * implement propagation * minor improvements * small fix * review fixes * [TEMP] set CI for new API * dictionary tidy up * add first test * fix helper and test for duplicates * Add missing sub-command * add unit-tests for coverage * change workersThreadPool_OnEvent* behavior to handle overlapping events * rename events after API update * implement managed and thread-safe slot ranges API * drop cached API when needed * rename API and use in the pipeline * move includes to C file * skip current flow test, and introduce a stable one * fix initial reference count * implement mock and add a test * add missing key-space notification subscription * add a test with adding a new node and propagating the schema * review fixes * fix assertion * leak fix * use malloc * leak actual fix * don't drop the cache on failed events * add BG variants to flow tests * feat: add slot ranges comparition logic * fix: change implementation * fix problems merging * fix problems merging * fix problems merging --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 70486dc)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
[MOD-12005] Add slot ranges comparison logic (#7130) * initial registration implementation * Set up most of the notification events * address review comment and add logs * implement propagation * minor improvements * small fix * review fixes * [TEMP] set CI for new API * dictionary tidy up * add first test * fix helper and test for duplicates * Add missing sub-command * add unit-tests for coverage * change workersThreadPool_OnEvent* behavior to handle overlapping events * rename events after API update * implement managed and thread-safe slot ranges API * drop cached API when needed * rename API and use in the pipeline * move includes to C file * skip current flow test, and introduce a stable one * fix initial reference count * implement mock and add a test * add missing key-space notification subscription * add a test with adding a new node and propagating the schema * review fixes * fix assertion * leak fix * use malloc * leak actual fix * don't drop the cache on failed events * add BG variants to flow tests * initial registration implementation * Set up most of the notification events * address review comment and add logs * implement propagation * minor improvements * small fix * review fixes * [TEMP] set CI for new API * dictionary tidy up * add first test * fix helper and test for duplicates * Add missing sub-command * add unit-tests for coverage * change workersThreadPool_OnEvent* behavior to handle overlapping events * rename events after API update * implement managed and thread-safe slot ranges API * drop cached API when needed * rename API and use in the pipeline * move includes to C file * skip current flow test, and introduce a stable one * fix initial reference count * implement mock and add a test * add missing key-space notification subscription * add a test with adding a new node and propagating the schema * review fixes * fix assertion * leak fix * use malloc * leak actual fix * don't drop the cache on failed events * add BG variants to flow tests * feat: add slot ranges comparition logic * fix: change implementation * fix problems merging * fix problems merging * fix problems merging --------- (cherry picked from commit 70486dc) Co-authored-by: Joan Fontanals <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Add logic to compare slot ranges
Note
Introduce
CompareSlotRangeswithSlotRangesComparisonResultand add C++ tests covering match/subset/non-inclusion and edge cases.SlotRangesComparisonResultenum andCompareSlotRanges(const RedisModuleSlotRangeArray* ranges_expected, const RedisModuleSlotRangeArray* ranges_actual)to compare slot range arrays (match, subset, does-not-include).src/slot_ranges.hwith API, documentation, and C linkage guards; forward-declareRedisModuleSlotRangeArray.tests/cpptests/test_cpp_slot_ranges.cppwith unit tests covering exact match, subsets (single/multiple), non-inclusion, overlaps, gaps, boundaries, and max slot values.Written by Cursor Bugbot for commit 7eda101. This will update automatically on new commits. Configure here.