bring back OOM work into branch#7069
Merged
JoanFM merged 1 commit intooshadmi_merge-master-into-feature-coordinator-hybridfrom Oct 15, 2025
Merged
bring back OOM work into branch#7069JoanFM merged 1 commit intooshadmi_merge-master-into-feature-coordinator-hybridfrom
JoanFM merged 1 commit intooshadmi_merge-master-into-feature-coordinator-hybridfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Free the error reply before we override it and continue | ||
| MRReply_Free(nc->current.root); | ||
| // Set it as NULL avoid another free | ||
| nc->current.root = NULL; |
There was a problem hiding this comment.
Bug: Error Handling Masks Critical Failures
The new error handling in rpnet.c only propagates QUERY_EGENERIC, QUERY_ETIMEDOUT, and QUERY_EOOM errors. Any other error type from extractQueryErrorFromReply is silently discarded, potentially masking critical failures and changing the previous, more general error behavior.
JoanFM
merged commit 63e1d78
into
oshadmi_merge-master-into-feature-coordinator-hybrid
13 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Captures shard errors in profiling and updates error propagation to parse error codes and respect timeout/OOM policies, including emitting OOM warnings when configured to continue.
src/coord/rpnet.c):forProfilingis set, clone and append the error toshardsProfile.extractQueryErrorFromReplyand decide to fail or continue based ontimeoutPolicyandoomPolicy.current.rootto avoid double free.Written by Cursor Bugbot for commit ef7382f. This will update automatically on new commits. Configure here.