Skip to content

[2.6] [MOD-10774] - test: add test validating crash from different timeout policies#7050

Merged
JoanFM merged 2 commits into2.6from
backport-7017-to-2.6
Oct 15, 2025
Merged

[2.6] [MOD-10774] - test: add test validating crash from different timeout policies#7050
JoanFM merged 2 commits into2.6from
backport-7017-to-2.6

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Oct 13, 2025

Description

Backport of #7017 to 2.6.


Note

Add a pytest that configures mixed shard timeout policies and verifies FT.AGGREGATE returns results (no coordinator crash) after bulk indexing.

  • Tests:
    • Add tests/pytests/test_cluster_aggregate_timeout.py:
      • Configures shard 1 with ON_TIMEOUT RETURN and others with ON_TIMEOUT FAIL + TIMEOUT 1.
      • Creates index idx, bulk-loads ~20k docs via pipelined HSET.
      • Runs FT.AGGREGATE with GROUPBY @category, COUNT, and AVG @price from shard 1 connection.
      • Asserts results length > 1 to validate coordinator stability under mixed timeout policies.

Written by Cursor Bugbot for commit ccf0d0c. This will update automatically on new commits. Configure here.

…policies (#7017)

* test: add test validating crash from different timeout policies

* test: improve test as per comments

* test: improve spped by using pipeline

* handle smaller amount of docs

* Update tests/pytests/test_cluster_aggregate_timeout.py

Co-authored-by: GuyAv46 <[email protected]>

---------

Co-authored-by: GuyAv46 <[email protected]>
(cherry picked from commit ea20c36)
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.38%. Comparing base (4e90fc9) to head (ccf0d0c).
⚠️ Report is 1 commits behind head on 2.6.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #7050      +/-   ##
==========================================
- Coverage   86.41%   86.38%   -0.04%     
==========================================
  Files         186      186              
  Lines       32270    32270              
==========================================
- Hits        27887    27875      -12     
- Misses       4383     4395      +12     
Flag Coverage Δ
flow 80.04% <ø> (-0.29%) ⬇️
unit 46.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoanFM JoanFM requested a review from GuyAv46 October 14, 2025 17:42
@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@JoanFM JoanFM added this pull request to the merge queue Oct 15, 2025
Merged via the queue into 2.6 with commit e1b6938 Oct 15, 2025
18 of 20 checks passed
@JoanFM JoanFM deleted the backport-7017-to-2.6 branch October 15, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants