[2.8] [MOD-10774] - test: add test validating crash from different timeout policies#7049
Merged
redisearch-backport-pull-request[bot] merged 3 commits into2.8from Oct 15, 2025
Merged
Conversation
…policies (#7017) * test: add test validating crash from different timeout policies * test: improve test as per comments * test: improve spped by using pipeline * handle smaller amount of docs * Update tests/pytests/test_cluster_aggregate_timeout.py Co-authored-by: GuyAv46 <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit ea20c36)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7049 +/- ##
==========================================
- Coverage 87.50% 87.49% -0.01%
==========================================
Files 203 203
Lines 35634 35636 +2
==========================================
Hits 31180 31180
- Misses 4454 4456 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7017 to
2.8.Note
Handle shard timeout with RETURN policy by discarding the error and resetting state; add a cluster test to prevent coordinator crashes under mixed timeout policies.
coord/src/dist_aggregate.c, when receiving"Timeout limit was reached"and the timeout policy is notFAIL, free the reply and reset state (RPNet_resetCurrent) instead of propagating an error.tests/pytests/test_cluster_aggregate_timeout.pyto validate mixed timeout policies across shards (coordinatorRETURN, othersFAIL) and ensure aggregate does not crash and returns results.Written by Cursor Bugbot for commit d602bd1. This will update automatically on new commits. Configure here.