[8.2] [MOD-10774] - test: add test validating crash from different timeout policies#7048
Merged
[8.2] [MOD-10774] - test: add test validating crash from different timeout policies#7048
Conversation
…policies (#7017) * test: add test validating crash from different timeout policies * test: improve test as per comments * test: improve spped by using pipeline * handle smaller amount of docs * Update tests/pytests/test_cluster_aggregate_timeout.py Co-authored-by: GuyAv46 <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit ea20c36)
GuyAv46
previously approved these changes
Oct 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
GuyAv46
approved these changes
Oct 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #7048 +/- ##
==========================================
- Coverage 89.46% 89.43% -0.04%
==========================================
Files 253 253
Lines 41665 41667 +2
Branches 3725 3725
==========================================
- Hits 37275 37264 -11
- Misses 4341 4354 +13
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7017 to
8.2.Note
Handle shard timeout errors under RETURN policy by discarding the error reply and resetting state, and add a cluster test validating mixed timeout policies don’t crash.
src/coord/dist_aggregate.c, when receivingMR_REPLY_ERRORwith message"Timeout limit was reached"and timeout policy is notFAIL(i.e., RETURN), free the reply and reset current state (RPNet_resetCurrent) instead of propagating an error.tests/pytests/test_cluster_aggregate_timeout.pyto configure shards with mixed timeout policies (RETURN on coordinator shard, FAIL on others) and validateFT.AGGREGATEreturns results without crashing.Written by Cursor Bugbot for commit a81cfc5. This will update automatically on new commits. Configure here.