[2.10] [MOD-10774] - test: add test validating crash from different timeout policies#7047
Merged
redisearch-backport-pull-request[bot] merged 3 commits into2.10from Oct 15, 2025
Merged
Conversation
…policies (#7017) * test: add test validating crash from different timeout policies * test: improve test as per comments * test: improve spped by using pipeline * handle smaller amount of docs * Update tests/pytests/test_cluster_aggregate_timeout.py Co-authored-by: GuyAv46 <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit ea20c36)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7047 +/- ##
==========================================
- Coverage 89.31% 89.28% -0.03%
==========================================
Files 207 207
Lines 36167 36169 +2
==========================================
- Hits 32301 32293 -8
- Misses 3866 3876 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Oct 15, 2025
redisearch-backport-pull-request
bot
deleted the
backport-7017-to-2.10
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7017 to
2.10.Note
Coordinator now discards shard timeout errors when ON_TIMEOUT=RETURN during distributed AGGREGATE, with a regression test covering mixed timeout policies.
"Timeout limit was reached"andON_TIMEOUTpolicy isRETURN, discard the error (MRReply_Free+RPNet_resetCurrent) instead of failing.test_cluster_aggregate_with_shards_timeoutverifying no crash when coordinator shard hasON_TIMEOUT=RETURNand other shardsON_TIMEOUT=FAILwith timeouts duringFT.AGGREGATE.Written by Cursor Bugbot for commit 5a0f2ff. This will update automatically on new commits. Configure here.