Skip to content

[2.10] Fix goto on RDB load#7037

Merged
GuyAv46 merged 1 commit into2.10from
backport-7033-to-2.10
Oct 13, 2025
Merged

[2.10] Fix goto on RDB load#7037
GuyAv46 merged 1 commit into2.10from
backport-7033-to-2.10

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Oct 13, 2025

Description

Backport of #7033 to 2.10.


Note

Adjusts IndexSpec_CreateFromRdb error handling to jump to a new cleanup_no_index label before spec allocation, preventing invalid cleanup and ensuring an error is set.

  • RDB Load:
    • Refines error handling in IndexSpec_CreateFromRdb by introducing cleanup_no_index and redirecting early failures (before spec allocation) to it, avoiding release of uninitialized refs and consistently setting QueryError.

Written by Cursor Bugbot for commit f766532. This will update automatically on new commits. Configure here.

fix goto

(cherry picked from commit 6cd3771)
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.28%. Comparing base (214978c) to head (f766532).
⚠️ Report is 1 commits behind head on 2.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #7037      +/-   ##
==========================================
- Coverage   89.31%   89.28%   -0.04%     
==========================================
  Files         207      207              
  Lines       36166    36167       +1     
==========================================
- Hits        32300    32290      -10     
- Misses       3866     3877      +11     
Flag Coverage Δ
flow 83.80% <100.00%> (-0.16%) ⬇️
unit 42.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GuyAv46 GuyAv46 added this pull request to the merge queue Oct 13, 2025
Merged via the queue into 2.10 with commit 438a8bd Oct 13, 2025
15 checks passed
@GuyAv46 GuyAv46 deleted the backport-7033-to-2.10 branch October 13, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants