Skip to content

[8.2] Fix goto on RDB load#7034

Merged
JoanFM merged 2 commits into8.2from
backport-7033-to-8.2
Oct 14, 2025
Merged

[8.2] Fix goto on RDB load#7034
JoanFM merged 2 commits into8.2from
backport-7033-to-8.2

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Oct 12, 2025

Description

Backport of #7033 to 8.2.


Note

Fixes the error-handling goto in IndexSpec_RdbLoad and updates spellcheck workflow to diff against origin/8.2.

  • Core (RDB load):
    • Introduces a separate early-failure cleanup label cleanup_no_index in IndexSpec_RdbLoad and redirects the initial LoadStringBuffer_IOError goto to it.
    • Adjusts cleanup flow to set the query error without touching index resources on early failures.
  • CI:
    • Spellcheck workflow now diffs against origin/8.2 and removes the explicit Fetch master step.

Written by Cursor Bugbot for commit bdbde33. This will update automatically on new commits. Configure here.

fix goto

(cherry picked from commit 6cd3771)
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.43%. Comparing base (67f4374) to head (bdbde33).
⚠️ Report is 1 commits behind head on 8.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.2    #7034      +/-   ##
==========================================
- Coverage   89.43%   89.43%   -0.01%     
==========================================
  Files         253      253              
  Lines       41664    41665       +1     
  Branches     3725     3725              
==========================================
  Hits        37262    37262              
- Misses       4353     4354       +1     
  Partials       49       49              
Flag Coverage Δ
flow 82.03% <100.00%> (-0.11%) ⬇️
unit 47.58% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Oct 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Oct 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2025
@JoanFM JoanFM added this pull request to the merge queue Oct 14, 2025
Merged via the queue into 8.2 with commit f9caadf Oct 14, 2025
19 checks passed
@JoanFM JoanFM deleted the backport-7033-to-8.2 branch October 14, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants