Skip to content

[2.6] Do not fanout FT.INFO command to replicas (#6960)#6998

Merged
JoanFM merged 1 commit into2.6from
backport-6960-to-2.6
Oct 8, 2025
Merged

[2.6] Do not fanout FT.INFO command to replicas (#6960)#6998
JoanFM merged 1 commit into2.6from
backport-6960-to-2.6

Conversation

@JoanFM
Copy link
Collaborator

@JoanFM JoanFM commented Oct 7, 2025

Backport #6960 to 2.6


Note

Change FT.INFO coordination to target only masters, avoiding fanout to replicas.

  • Coordinator:
    • FT.INFO: Switch MR_SetCoordinationStrategy from MRCluster_FlatCoordination to MRCluster_MastersOnly in coord/src/module.c, so the command executes only on master nodes.

Written by Cursor Bugbot for commit 5759a9f. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

@JoanFM JoanFM requested a review from GuyAv46 October 7, 2025 09:07
The current behaviour of the coordinator is not correct, because FT.INFO command reports the number of docs as actual number of docs multiplied by number of replicas

(cherry picked from commit 8eb5ce5)
@JoanFM JoanFM force-pushed the backport-6960-to-2.6 branch from 8a2a2dc to 5759a9f Compare October 7, 2025 09:11
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.38%. Comparing base (e8d53d9) to head (5759a9f).
⚠️ Report is 3 commits behind head on 2.6.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #6998      +/-   ##
==========================================
- Coverage   86.41%   86.38%   -0.04%     
==========================================
  Files         186      186              
  Lines       32270    32270              
==========================================
- Hits        27887    27875      -12     
- Misses       4383     4395      +12     
Flag Coverage Δ
flow 80.04% <100.00%> (-0.29%) ⬇️
unit 46.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoanFM JoanFM added this pull request to the merge queue Oct 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2025
Do not fanout FT.INFO command to replicas (#6960)

The current behaviour of the coordinator is not correct, because FT.INFO command reports the number of docs as actual number of docs multiplied by number of replicas

(cherry picked from commit 8eb5ce5)

Co-authored-by: Igor Malinovskiy <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2025
@JoanFM JoanFM added this pull request to the merge queue Oct 8, 2025
Merged via the queue into 2.6 with commit 2d4db06 Oct 8, 2025
14 checks passed
@JoanFM JoanFM deleted the backport-6960-to-2.6 branch October 8, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants