[2.10] Do not fanout FT.INFO command to replicas (#6960)#6996
Merged
Conversation
The current behaviour of the coordinator is not correct, because FT.INFO command reports the number of docs as actual number of docs multiplied by number of replicas (cherry picked from commit 8eb5ce5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #6996 +/- ##
==========================================
- Coverage 89.32% 89.28% -0.04%
==========================================
Files 207 207
Lines 36165 36164 -1
==========================================
- Hits 32304 32289 -15
- Misses 3861 3875 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Oct 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
Do not fanout FT.INFO command to replicas (#6960) The current behaviour of the coordinator is not correct, because FT.INFO command reports the number of docs as actual number of docs multiplied by number of replicas (cherry picked from commit 8eb5ce5) Co-authored-by: Igor Malinovskiy <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Performance Improvements - Comparison between 2.10 and backport-6960-to-2.10.Time Period from 30 days ago. (environment used: oss-standalone)
Performance Regressions and Issues - Comparison between 2.10 and backport-6960-to-2.10.Time Period from 30 days ago. (environment used: oss-standalone)
Tests with No Significant Changes (8 tests)Tests with No Significant Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6960 to 2.10
Note
FT.INFO no longer fans out to replicas; it now targets only master shards by removing the all-shards coordination strategy.
InfoCommandHandlerincoord/src/module.cto stop usingMR_SetCoordinationStrategy(..., false), soFT.INFOfans out only to masters (not replicas).Written by Cursor Bugbot for commit 185d98b. This will update automatically on new commits. Configure here.