[2.8] [MOD-10076] - remove the FDs check in gc oom test#6925
Merged
redisearch-backport-pull-request[bot] merged 1 commit into2.8from Sep 29, 2025
Merged
[2.8] [MOD-10076] - remove the FDs check in gc oom test#6925redisearch-backport-pull-request[bot] merged 1 commit into2.8from
redisearch-backport-pull-request[bot] merged 1 commit into2.8from
Conversation
* add wait for gc * remove FDs check * add wait for gc * remove FDs check (cherry picked from commit 44d4914)
BenGoldberger
approved these changes
Sep 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6925 +/- ##
==========================================
- Coverage 87.50% 87.49% -0.01%
==========================================
Files 203 203
Lines 35634 35634
==========================================
- Hits 31181 31178 -3
- Misses 4453 4456 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
redisearch-backport-pull-request
bot
deleted the
backport-6903-to-2.8
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6903 to
2.8.Note
Simplifies
test_gc_oomby removing file-descriptor checks (andpsutil) and invoking GC once after deletions.tests/pytests/test_gc.py:psutilimport andget_open_file_counthelper.test_gc_oom.forceInvokeGC(env)once after deleting all docs; keep GC bytes_collected checks and post-memory-increase GC run.Written by Cursor Bugbot for commit bff1ec6. This will update automatically on new commits. Configure here.