[8.4]: Cherry-pick #6913 Add missing lines after feature branch merge (#6913)#6919
Merged
[8.4]: Cherry-pick #6913 Add missing lines after feature branch merge (#6913)#6919
Conversation
add missing lines after feature branch merge (cherry picked from commit cc952f2)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GuyAv46
previously approved these changes
Sep 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #6919 +/- ##
==========================================
- Coverage 86.12% 86.11% -0.01%
==========================================
Files 308 308
Lines 49446 49448 +2
Branches 9543 9543
==========================================
- Hits 42586 42584 -2
- Misses 6710 6714 +4
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nafraf
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #6913 to 8.4
add missing lines after feature branch merge
(cherry picked from commit cc952f2)
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable
Note
Transfers root iterator ownership to the pipeline and updates pack min Redis versions to 8.4.
rootitermoved to the pipeline:src/aggregate/aggregate_request.c(AREQ_BuildPipeline), setreq->rootiter = NULLafter passing it viaQueryPipelineParams.src/pipeline/pipeline_construction.c(Pipeline_BuildQueryPart), setparams->rootiter = NULLafter creatingRPQueryIterator.pack/ramp-community.ymlandpack/ramp-enterprise.ymltomin_redis_version: "8.4"andmin_redis_pack_version: "8.4".Written by Cursor Bugbot for commit f95f56f. This will update automatically on new commits. Configure here.