[2.10] [MOD-11611] fix test_vecsim:TestTimeoutReached #6910
Merged
Conversation
* test: update KNN query to use large_k and remove redundant checks * revert unnecessary changes (cherry picked from commit 8e2dd9b)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #6910 +/- ##
==========================================
- Coverage 89.31% 89.28% -0.04%
==========================================
Files 207 207
Lines 36165 36165
==========================================
- Hits 32302 32291 -11
- Misses 3863 3874 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meiravgri
approved these changes
Sep 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6904 to
2.10.Note
In
TestTimeoutReached, uselarge_k=1000for no-timeout KNN and remove no-timeout success checks for RANGE and HYBRID queries, keeping only timeout-failure validations.tests/pytests/test_vecsim.py):TestTimeoutReached:large_k = 1000; use it for no-timeout KNN (LIMIT/K) and update assertions.@vector:[VECTOR_RANGE ...]and HYBRID (HYBRID_POLICY) queries; retain 1ms timeout error checks.Written by Cursor Bugbot for commit 3986666. This will update automatically on new commits. Configure here.