[2.8] [MOD-11611] fix test_vecsim:TestTimeoutReached #6909
Merged
redisearch-backport-pull-request[bot] merged 1 commit into2.8from Sep 28, 2025
Merged
[2.8] [MOD-11611] fix test_vecsim:TestTimeoutReached #6909redisearch-backport-pull-request[bot] merged 1 commit into2.8from
redisearch-backport-pull-request[bot] merged 1 commit into2.8from
Conversation
* test: update KNN query to use large_k and remove redundant checks * revert unnecessary changes (cherry picked from commit 8e2dd9b)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| 'PARAMS', 4, 'K', large_k, 'vec_param', query_vec.tobytes(), | ||
| 'TIMEOUT', 0) | ||
| self.env.assertEqual(res[0], n_vec) | ||
| self.env.assertEqual(res[0], large_k) |
There was a problem hiding this comment.
Bug: Inconsistent KNN Test Parameters
The FT.SEARCH KNN tests use inconsistent K and LIMIT parameters. The no-timeout test uses large_k (1000), but the timeout test still uses n_vec (a much larger value). This means the tests aren't comparing the same query, which makes the timeout test unreliable.
meiravgri
approved these changes
Sep 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6909 +/- ##
==========================================
- Coverage 87.50% 87.49% -0.01%
==========================================
Files 203 203
Lines 35634 35634
==========================================
- Hits 31181 31178 -3
- Misses 4453 4456 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
redisearch-backport-pull-request
bot
deleted the
backport-6904-to-2.8
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6904 to
2.8.Note
Adjust TestTimeoutReached to use fixed K=1000 for no-timeout KNN and drop no-timeout success checks for range and hybrid queries, keeping only timeout failure checks.
tests/pytests/test_vecsim.py):large_k = 1000; use it for no-timeout KNN (LIMIT/K) and assert result count accordingly.Written by Cursor Bugbot for commit 7beb820. This will update automatically on new commits. Configure here.