mov repairInvIndex logic and friends from gc to II#6844
Conversation
or was added by accident
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
Looks good. There is just a single block ref access and number of entries setter left in the fork. I think we'll be able to live with these (esp the block ref access)
Ok so in that case I think we are "done" with the C side of this umbrella fork_gc story, no? And I can move after this to the Rust side? |
Yes, I would say you can start with the Rust side if you did not already |
meiravgri
left a comment
meiravgri
left a comment
There was a problem hiding this comment.
Looks good!
few small comments
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Feedback from you and cursor resoled AFAIK. In meanwhile the Rust work is well under way. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6844 +/- ##
==========================================
- Coverage 86.34% 86.30% -0.04%
==========================================
Files 303 303
Lines 48529 48553 +24
Branches 9543 9543
==========================================
+ Hits 41901 41903 +2
- Misses 6478 6500 +22
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 participants
Describe the changes in the pull request
Continuation of work done for https://redislabs.atlassian.net/browse/MOD-10702 (Implement ForkGc for inverted index in Rust).
Move scan/apply logic specific to II or its internals to II code, in a continued
attempt to keep the II surface touched by fork_gc as abstract and high level as possible.
Closes:
Mark if applicable