fix: RLookupRow use-after-free due to inconsistent refcount handling#6838
Merged
LukeMathWalker merged 1 commit intomasterfrom Sep 22, 2025
Merged
fix: RLookupRow use-after-free due to inconsistent refcount handling#6838LukeMathWalker merged 1 commit intomasterfrom
LukeMathWalker merged 1 commit intomasterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JonasKruckenberg
force-pushed
the
jonas/fix-rlookuprow
branch
2 times, most recently
from
9391fce to
b56fd90
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6838 +/- ##
==========================================
- Coverage 86.36% 86.35% -0.02%
==========================================
Files 288 288
Lines 46520 46515 -5
Branches 9404 9399 -5
==========================================
- Hits 40176 40166 -10
- Misses 6193 6198 +5
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JonasKruckenberg
force-pushed
the
jonas/fix-rlookuprow
branch
from
b56fd90 to
3589e2b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JonasKruckenberg
force-pushed
the
jonas/fix-rlookuprow
branch
2 times, most recently
from
5b8af48 to
0df368a
Compare
JonasKruckenberg
force-pushed
the
jonas/fix-rlookuprow
branch
4 times, most recently
from
dec451b to
f6a3826
Compare
JonasKruckenberg
force-pushed
the
jonas/fix-rlookuprow
branch
from
f6a3826 to
ccb21e5
Compare
LukeMathWalker
approved these changes
Sep 22, 2025
nafraf
pushed a commit
that referenced
this pull request
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes use-after free due to inconsistent handling of refcounts in
RLookupRowandvalue. The test mock implementation did not implementDropand used a weirdRc-based workaround for refcount increases while the "production"RSValueFFIimplementedDropandCloneusing atomic refcounting. This lead to a mismatch between test-behavior and "production" behavior where tests passing would mean the runtime behavior was incorrect.This change simplifies
MockRSValueto also use atomic reference counting, removes the manual and unsafeincrementanddecrementmethods ofRSValueTraitand fixes the uses inRLookupRowto be correct.