remove extra RWlock init#6823
Merged
kei-nan merged 1 commit intomaster_jk_add_rdb_index_spec_testsfrom Sep 12, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master_jk_add_rdb_index_spec_tests #6823 +/- ##
======================================================================
- Coverage 87.18% 87.18% -0.01%
======================================================================
Files 288 288
Lines 46023 46022 -1
Branches 8954 8954
======================================================================
- Hits 40127 40125 -2
- Misses 5745 5746 +1
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kei-nan
approved these changes
Sep 12, 2025
kei-nan
pushed a commit
that referenced
this pull request
Sep 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 21, 2025
…nitialization (#6817) * initial commit * prepare code for CI run * move terms and fieldIdToIndex initialization to initializeIndexSpec * cleanup test a bit * remove extra RWlock init (#6823) * fix code review comments * remove print from mock * remove print from mock functions * code review comment * remove log remainder * switch rm_calloc arg order * add initializeFieldSpec function --------- Co-authored-by: Joan Fontanals <[email protected]>
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Sep 21, 2025
…nitialization (#6817) * initial commit * prepare code for CI run * move terms and fieldIdToIndex initialization to initializeIndexSpec * cleanup test a bit * remove extra RWlock init (#6823) * fix code review comments * remove print from mock * remove print from mock functions * code review comment * remove log remainder * switch rm_calloc arg order * add initializeFieldSpec function --------- Co-authored-by: Joan Fontanals <[email protected]> (cherry picked from commit a73f3f7)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 21, 2025
…ield initialization (#6866) MOD-11190: Add IndexSpec RDB Comparison Tests - Fix Index RDB field initialization (#6817) * initial commit * prepare code for CI run * move terms and fieldIdToIndex initialization to initializeIndexSpec * cleanup test a bit * remove extra RWlock init (#6823) * fix code review comments * remove print from mock * remove print from mock functions * code review comment * remove log remainder * switch rm_calloc arg order * add initializeFieldSpec function --------- (cherry picked from commit a73f3f7) Co-authored-by: kei-nan <[email protected]> Co-authored-by: Joan Fontanals <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable