Conversation
JoanFM
reviewed
Sep 3, 2025
src/config.h
Outdated
| static const int on_timeout_enums[2] = { | ||
| TimeoutPolicy_Return, | ||
| TimeoutPolicy_Fail | ||
| FailurePolicy_Return, // Return what we have on timeout |
Collaborator
There was a problem hiding this comment.
Suggested change
| FailurePolicy_Return, // Return what we have on timeout | |
| FailurePolicy_Return, // Return what we have on failure (timeout or OOM) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6769 +/- ##
==========================================
- Coverage 87.23% 87.20% -0.04%
==========================================
Files 287 287
Lines 45241 45265 +24
Branches 8239 8238 -1
==========================================
+ Hits 39466 39473 +7
- Misses 5650 5667 +17
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGoldberger
approved these changes
Sep 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
* Change variables name from Timeout (specific) to Failure (general) * Add ON_OOM configuration option and related functionality * Change comment is FailurePolicy * Add coverage
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lerman25
added a commit
that referenced
this pull request
Sep 24, 2025
YaacovHazan
pushed a commit
to redis/redis
that referenced
this pull request
Oct 27, 2025
(RediSearch/RediSearch#7076, RediSearch/RediSearch#6857) - Introducing `FT.HYBRID`, a new command that enables hybrid queries combining both text and vector search, with support for **RRF** and **LINEAR** result combination. This update enhances performance and reliability through a more efficient networking layer, smoother query execution, and improved overall stability. (RediSearch/RediSearch#7065) - Add `search-default-scorer` configuration to set the default text scorer across queries (by default it is BM25). RediSearch/RediSearch#7022 - Handle Atomic Slot Migration events upon moving slots from one node to another in a cluster mode. (RediSearch/RediSearch#6769, RediSearch/RediSearch#6828, RediSearch/RediSearch#6877, RediSearch/RediSearch#6921) - Introduce query time memory guardrails by adding a new `search-on-oom` configuration which defines the query engine behavior when OOM (Out Of Memory) is reached. OOM checks are applied to `FT.SEARCH`, `FT.AGGREGATE`, and `FT.HYBRID` commands. The behavior on OOM can be configured to one of three modes: `IGNORE`, `FAIL`, or `RETURN`. `IGNORE` - The default behavior, run queries anyway (not recommended for heavy queries returning a large result set). `FAIL` - Fail query execution immediately if any of the nodes are in OOM state when query execution starts. `RETURN` - A best effort appraoch to return partial results when OOM is detected in only some of the nodes in a cluster mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new search config, ON_OOM.
It's identical to ON_TIMEOUT config, but controls the behavior when query has reached OOM stats.