Merged
Conversation
GuyAv46
approved these changes
Sep 2, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a casting bug in the rpcountFree function where the result processor was incorrectly cast to RPScorer instead of RPCounter. This ensures the proper type is used when freeing counter result processor resources.
- Corrects incorrect type casting in the counter result processor's free function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6762 +/- ##
==========================================
- Coverage 87.23% 87.19% -0.04%
==========================================
Files 288 288
Lines 45262 45262
Branches 8109 8109
==========================================
- Hits 39484 39468 -16
- Misses 5655 5671 +16
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oshadmi
approved these changes
Sep 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
MOD-11216: Fix rpcountFree casting (#6762) * Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f) Co-authored-by: Raz Monsonego <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
MOD-11216: Fix rpcountFree casting (#6762) * Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f) Co-authored-by: Raz Monsonego <[email protected]>
lerman25
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Fix rpcountFree casting * Remove comment
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
MOD-11216: Fix rpcountFree casting (#6762) * Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f) Co-authored-by: Raz Monsonego <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
MOD-11216: Fix rpcountFree casting (#6762) * Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f) Co-authored-by: Raz Monsonego <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
MOD-11216: Fix rpcountFree casting (#6762) * Fix rpcountFree casting * Remove comment (cherry picked from commit 02a2c3f) Co-authored-by: Raz Monsonego <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bad casting in the free function logic of the counter result processor.
Introduced in #1891.