Skip to content

[2.10] MOD-10975: Fix fd leak when OOM (#6672)#6702

Merged
nafraf merged 1 commit into2.10from
nafraf_backport-6672-to-2.10
Aug 28, 2025
Merged

[2.10] MOD-10975: Fix fd leak when OOM (#6672)#6702
nafraf merged 1 commit into2.10from
nafraf_backport-6672-to-2.10

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented Aug 24, 2025

Description

Manual backport of #6672 to 2.10.
(cherry picked from commit 56f6f0e)

Changes:

  • Fix conflict in test_gc_oom() to create index before adding the docs.
  • Fix conflict in test_gc_oom() to call set_tight_maxmemory_for_oom(env) instead of env.expect('config', 'set', 'maxmemory', 1).ok()

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (a0cd5c3) to head (236266f).
⚠️ Report is 3 commits behind head on 2.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #6702      +/-   ##
==========================================
- Coverage   89.32%   89.30%   -0.02%     
==========================================
  Files         207      207              
  Lines       36140    36142       +2     
==========================================
- Hits        32282    32277       -5     
- Misses       3858     3865       +7     
Flag Coverage Δ
flow 83.82% <100.00%> (-0.15%) ⬇️
unit 42.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nafraf nafraf requested review from oshadmi and raz-mon August 24, 2025 22:23
@nafraf nafraf added this pull request to the merge queue Aug 28, 2025
Merged via the queue into 2.10 with commit 037b269 Aug 28, 2025
11 checks passed
@nafraf nafraf deleted the nafraf_backport-6672-to-2.10 branch August 28, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants