MOD-11012: Fix VSIM filter not working in hybrid queries#6692
Closed
Itzikvaknin wants to merge 136 commits intofeature-RRFfrom
Closed
MOD-11012: Fix VSIM filter not working in hybrid queries#6692Itzikvaknin wants to merge 136 commits intofeature-RRFfrom
Itzikvaknin wants to merge 136 commits intofeature-RRFfrom
Conversation
…d parameter parsing
… for improved parameter validation and consistency
…roved attribute handling and memory management
remove redundent code in aggregate request
….c and hybrid_execution.h files
…to src/aggregate/aggregate_exec_common.h
…ildPipelineAndExecute parameters
…redundant static declarations and improving code organization.
Should prevent accidental breaking of the CI.
Itzikvaknin
force-pushed
the
ivaknin-fix_vsim_filter_clause
branch
from
cc32164 to
4251e20
Compare
raz-mon
previously approved these changes
Aug 24, 2025
Collaborator
raz-mon
left a comment
raz-mon
left a comment
There was a problem hiding this comment.
Use also for other AREQ initialization places if relevant (should be)
kei-nan
previously approved these changes
Aug 24, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature-RRF #6692 +/- ##
==============================================
Coverage ? 88.40%
==============================================
Files ? 261
Lines ? 42761
Branches ? 3630
==============================================
Hits ? 37801
Misses ? 4911
Partials ? 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Itzikvaknin
dismissed stale reviews from kei-nan and raz-mon
The base branch was changed.
Collaborator
Author
|
Changes were merged in #6708 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move upstream AREQs common initialization logic into helper functions
initializeAREQ() and createDetachedSearchContext() to ensure consistent
setup across search and vector requests.