Closed
Conversation
…d parameter parsing
… for improved parameter validation and consistency
…roved attribute handling and memory management
remove redundent code in aggregate request
…havior is no longer expected
…streams pipelines
…ds them, to avoid double free
… it yields them, to avoid double free" This reverts commit 7ab1d97.
…er_Next_Yield function
Itzikvaknin
reviewed
Aug 19, 2025
| HybridScoringContext *hybridScoringCtx = HybridScoringContext_NewRRF(k, window, false); | ||
|
|
||
| return RPHybridMerger_New(hybridScoringCtx, upstreams, numUpstreams, NULL); | ||
| return RPHybridMerger_New(hybridScoringCtx, upstreams, numUpstreams, NULL, NULL, NULL); |
Itzikvaknin
reviewed
Aug 19, 2025
Contributor
Author
There was a problem hiding this comment.
yes, this is how you turn a directory into a python module so you can import from it
ofiryanai
force-pushed
the
rrf-flow-tests-only
branch
from
8b0228a to
4767db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only flow tests with no comparison table, see
rrf-flow-testsbranch with some changes in the C code that output the rank in subqueries but leaks them, and writes comparison table in failing tests that's very useful for debugging.