Conversation
GuyAv46
previously approved these changes
Aug 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 856c375 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #6652 +/- ##
==========================================
- Coverage 87.54% 87.47% -0.07%
==========================================
Files 282 282
Lines 44801 44840 +39
Branches 7721 7753 +32
==========================================
+ Hits 39222 39226 +4
- Misses 5459 5494 +35
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Aug 19, 2025
nafraf
pushed a commit
that referenced
this pull request
Aug 21, 2025
* bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 24, 2025
* Close pipe file descriptors in periodic callback to prevent resource leaks * Add open file count check in OOM test * build_utils: factor out link_static_libraries() (#6673) Will help implementing the iterator bencher. * [MOD-10771] bump svs version (#6652) * bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage * ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. * get open fds using psutil.num_fds() --------- Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: meiravgri <[email protected]>
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Aug 24, 2025
* Close pipe file descriptors in periodic callback to prevent resource leaks * Add open file count check in OOM test * build_utils: factor out link_static_libraries() (#6673) Will help implementing the iterator bencher. * [MOD-10771] bump svs version (#6652) * bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage * ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. * get open fds using psutil.num_fds() --------- Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: meiravgri <[email protected]> (cherry picked from commit 56f6f0e)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 24, 2025
MOD-10975: Fix fd leak when OOM (#6672) * Close pipe file descriptors in periodic callback to prevent resource leaks * Add open file count check in OOM test * build_utils: factor out link_static_libraries() (#6673) Will help implementing the iterator bencher. * [MOD-10771] bump svs version (#6652) * bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage * ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. * get open fds using psutil.num_fds() --------- (cherry picked from commit 56f6f0e) Co-authored-by: nafraf <[email protected]> Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: meiravgri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes vecsim version that points to the new binary version of svs with the fix to address the bug (crash) described in
MOD-10771