Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6651 +/- ##
==========================================
- Coverage 87.48% 87.45% -0.03%
==========================================
Files 282 282
Lines 44844 44840 -4
Branches 7747 7751 +4
==========================================
- Hits 39231 39217 -14
- Misses 5495 5503 +8
- Partials 118 120 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
reviewed
Aug 14, 2025
raz-mon
previously approved these changes
Aug 14, 2025
oshadmi
reviewed
Aug 20, 2025
Collaborator
|
Reproduced by sending a write command on Enterprise on an existing index: @oshadmi This will be tested once we run our flow-tests on RE, something that is long due and planned for the short term AFAIK. For now tested manually. |
raz-mon
approved these changes
Aug 25, 2025
oshadmi
approved these changes
Aug 26, 2025
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Allow access in ACLUserMayAccessIndex when no user is associated * Touchup --------- Co-authored-by: Raz Monsonego <[email protected]> (cherry picked from commit 3ec7115)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
MOD-10748: Fix ACLUserMayAccessIndex (#6651) * Allow access in ACLUserMayAccessIndex when no user is associated * Touchup --------- (cherry picked from commit 3ec7115) Co-authored-by: nafraf <[email protected]> Co-authored-by: Raz Monsonego <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
In Redis, the "master" client (such as replication) may not have an associated user, and
RedisModule_GetCurrentUserName()will return NULL in such cases.Redisearch was not validating the previous case.
Allow access in ACLUserMayAccessIndex when no user is associated
Similar approach was used by RedisTimeSeries in CheckKeyIsAllowedByAcls
Mark if applicable