Iterators refactor - Replace Old Iterators implementation with the new ones - [MOD-8850]#6572
Merged
Iterators refactor - Replace Old Iterators implementation with the new ones - [MOD-8850]#6572
Conversation
GuyAv46
added
enforce:coverage
GuyAv46
force-pushed
the
guyav-replace_old_iterators
branch
from
32aee8a to
b00ed89
Compare
JoanFM
reviewed
Aug 5, 2025
JoanFM
reviewed
Aug 5, 2025
JoanFM
reviewed
Aug 5, 2025
JoanFM
previously approved these changes
Aug 5, 2025
alonre24
reviewed
Aug 5, 2025
Collaborator
alonre24
left a comment
alonre24
left a comment
There was a problem hiding this comment.
few more small questions
Comment on lines
+687
to
+691
| if (term && sctx) { | ||
| // compute IDF based on num of docs in the header | ||
| term->idf = CalculateIDF(sctx->spec->docs.size, idx->numDocs); // FIXME: docs.size starts at 1??? | ||
| term->bm25_idf = CalculateIDF_BM25(sctx->spec->stats.numDocuments, idx->numDocs); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why do we need that for tags? they are not supposed to be scorable
Collaborator
Author
There was a problem hiding this comment.
But they are today. Maybe because there was no dedicated API for them or another reason, but I don't intend to change that on this PR.
We can remove this part in the future.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alonre24
previously approved these changes
Aug 5, 2025
JoanFM
approved these changes
Aug 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Replacing old implementation usage with the new one, and deleting the old implementation + any now-dead code.
Additional changes
iteratorsdirectory, and align their flow to the new API (mainly changing the struct and adding the newRevalidateAPI)index.cfileMark if applicable