ci: pin a Rust nightly version by gdesmott · Pull Request #6513 · RediSearch/RediSearch

gdesmott · 2025-07-21T09:23:52Z

Should prevent accidental breaking of the CI.

Mark if applicable

This PR introduces API changes
This PR introduces serialization changes

.install/test_deps/common_installations.sh

codecov · 2025-07-21T13:24:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.48%. Comparing base (08a333a) to head (ead9055).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6513      +/-   ##
==========================================
- Coverage   87.49%   87.48%   -0.02%     
==========================================
  Files         282      282              
  Lines       44840    44838       -2     
  Branches     7753     7751       -2     
==========================================
- Hits        39234    39225       -9     
- Misses       5486     5493       +7     
  Partials      120      120

Flag	Coverage Δ
flow	`84.52% <ø> (-0.14%)`	⬇️
unit	`49.26% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gdesmott · 2025-07-22T06:38:46Z

@raz-mon : I'm afraid this is not going to work.

RedisJSON relies on nightly as well and no longer find it as it looks for the latest one:
https://github.com/RediSearch/RediSearch/actions/runs/16418681005/job/46391047723?pr=6513#step:18:231

So we need a way to pin the same version across repos. I'm not sure what would be a convenient way to do that?

Or we could install the latest nightly as part of the RedisJSON setup. If we just need to build it and use the module directly then it's fine having two different nightly version.

gdesmott · 2025-07-22T08:00:44Z

@chesedo @DarthB any suggestion?

chesedo · 2025-07-22T13:33:12Z

@chesedo @DarthB any suggestion?

No, sorry I don't see an easy way around this. The proper solution is having a unified system for all the CIs, but that is a big undertaking for another time.

Maybe using a pre-build (Rust) image for all the CI is a step in that direction and would be quicker to make. But that still requires some co-ordination.

gdesmott · 2025-07-28T15:11:59Z

@alonre24 I opened RedisJSON/RedisJSON#1362 on RedisJSON.

Another (ugly) option would be to install both nightly versions as a workaround; see my second commit in this PR.

gdesmott · 2025-07-31T12:35:46Z

@alonre24 : I tested locally with version nightly-2025-07-30 which works fine.

So once RedisJSON has pinned this version as well we can merge this.

build.sh

Should prevent accidental breaking of the CI.

gdesmott · 2025-08-21T08:19:49Z

For the record here are the PR pinning the same version in RediJSON and redismodule-rs:

alonre24 · 2025-08-21T11:33:51Z

/backport

Should prevent accidental breaking of the CI. (cherry picked from commit 588fb97)

redisearch-backport-pull-request · 2025-08-21T11:34:06Z

Successfully created backport PR for 8.2:

[8.2] ci: pin a Rust nightly version #6685

Should prevent accidental breaking of the CI.

alonre24 · 2025-08-24T09:41:54Z

/backport

redisearch-backport-pull-request · 2025-08-24T09:42:04Z

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-6513-to-2.8 origin/2.8
cd .worktree/backport-6513-to-2.8
git switch --create backport-6513-to-2.8
git cherry-pick -x 588fb97b3f209d26bd77071cae48986d539feebe

redisearch-backport-pull-request · 2025-08-24T09:42:05Z

Backport failed for 2.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.6
git worktree add -d .worktree/backport-6513-to-2.6 origin/2.6
cd .worktree/backport-6513-to-2.6
git switch --create backport-6513-to-2.6
git cherry-pick -x 588fb97b3f209d26bd77071cae48986d539feebe

redisearch-backport-pull-request · 2025-08-24T09:42:06Z

Backport failed for 2.10, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.10
git worktree add -d .worktree/backport-6513-to-2.10 origin/2.10
cd .worktree/backport-6513-to-2.10
git switch --create backport-6513-to-2.10
git cherry-pick -x 588fb97b3f209d26bd77071cae48986d539feebe

* Close pipe file descriptors in periodic callback to prevent resource leaks * Add open file count check in OOM test * build_utils: factor out link_static_libraries() (#6673) Will help implementing the iterator bencher. * [MOD-10771] bump svs version (#6652) * bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage * ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. * get open fds using psutil.num_fds() --------- Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: meiravgri <[email protected]>

* Close pipe file descriptors in periodic callback to prevent resource leaks * Add open file count check in OOM test * build_utils: factor out link_static_libraries() (#6673) Will help implementing the iterator bencher. * [MOD-10771] bump svs version (#6652) * bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage * ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. * get open fds using psutil.num_fds() --------- Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: meiravgri <[email protected]> (cherry picked from commit 56f6f0e)

MOD-10975: Fix fd leak when OOM (#6672) * Close pipe file descriptors in periodic callback to prevent resource leaks * Add open file count check in OOM test * build_utils: factor out link_static_libraries() (#6673) Will help implementing the iterator bencher. * [MOD-10771] bump svs version (#6652) * bump vecsim * vecsim with fix * test crash * code change to trigger tests * revert code chnage * ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. * get open fds using psutil.num_fds() --------- (cherry picked from commit 56f6f0e) Co-authored-by: nafraf <[email protected]> Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: meiravgri <[email protected]>

This reverts commit 899e722.

ci: pin a Rust nightly version (#6513) Should prevent accidental breaking of the CI. (cherry picked from commit 588fb97) Co-authored-by: Guillaume Desmottes <[email protected]>

github-actions bot added the size:XS label Jul 21, 2025

gdesmott requested a review from chesedo July 21, 2025 09:44

raz-mon previously approved these changes Jul 21, 2025

View reviewed changes

gdesmott dismissed raz-mon’s stale review via 756e259 July 21, 2025 11:35

gdesmott force-pushed the nightly branch from d1892c6 to 756e259 Compare July 21, 2025 11:35

chesedo reviewed Jul 21, 2025

View reviewed changes

.install/test_deps/common_installations.sh Show resolved Hide resolved

gdesmott force-pushed the nightly branch from 756e259 to 67a996a Compare July 21, 2025 12:33

github-actions bot added the size:S label Jul 21, 2025

gdesmott added enforce:coverage Run coverage flow even on draft pull request enforce:sanitize Run sanitizer flow even on draft pull request labels Jul 21, 2025

gdesmott force-pushed the nightly branch from 67a996a to a150f8d Compare July 21, 2025 12:53

chesedo previously approved these changes Jul 21, 2025

View reviewed changes

gdesmott dismissed chesedo’s stale review via e2e5c93 July 21, 2025 13:40

gdesmott force-pushed the nightly branch 2 times, most recently from e2e5c93 to 81c04d8 Compare July 21, 2025 13:43

gdesmott force-pushed the nightly branch from 81c04d8 to 5f00240 Compare July 28, 2025 11:01

gdesmott mentioned this pull request Jul 28, 2025

Pin a Rust nighlty version RedisJSON/RedisJSON#1362

Open

gdesmott force-pushed the nightly branch 4 times, most recently from 7087e5e to a6aa30c Compare July 31, 2025 12:30

alonre24 reviewed Jul 31, 2025

View reviewed changes

build.sh Show resolved Hide resolved

gdesmott force-pushed the nightly branch from a6aa30c to ac6a41e Compare July 31, 2025 12:40

gdesmott force-pushed the nightly branch from ac6a41e to 666fef9 Compare August 20, 2025 13:18

ci: pin a Rust nightly version

ead9055

Should prevent accidental breaking of the CI.

gdesmott force-pushed the nightly branch from 233e54a to ead9055 Compare August 21, 2025 08:13

chesedo approved these changes Aug 21, 2025

View reviewed changes

gdesmott enabled auto-merge August 21, 2025 09:16

gdesmott added this pull request to the merge queue Aug 21, 2025

Merged via the queue into master with commit 588fb97 Aug 21, 2025
17 checks passed

gdesmott deleted the nightly branch August 21, 2025 10:48

alonre24 added the backport 8.2 label Aug 21, 2025

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Aug 21, 2025

ci: pin a Rust nightly version (#6513)

998f44e

Should prevent accidental breaking of the CI. (cherry picked from commit 588fb97)

redisearch-backport-pull-request bot mentioned this pull request Aug 21, 2025

[8.2] ci: pin a Rust nightly version #6685

Merged

oshadmi added backport 2.10 backport 2.8 backport 2.6 labels Aug 21, 2025

nafraf pushed a commit that referenced this pull request Aug 21, 2025

ci: pin a Rust nightly version (#6513)

6fbe0f3

Should prevent accidental breaking of the CI.

Itzikvaknin pushed a commit that referenced this pull request Aug 21, 2025

ci: pin a Rust nightly version (#6513)

899e722

Should prevent accidental breaking of the CI.

alonre24 removed the backport 8.2 label Aug 24, 2025

alonre24 mentioned this pull request Aug 24, 2025

[2.10] pin a Rust nightly version #6693

Merged

2 tasks

Itzikvaknin added a commit that referenced this pull request Aug 25, 2025

Revert "ci: pin a Rust nightly version (#6513)"

cde78e1

This reverts commit 899e722.

Conversation

gdesmott commented Jul 21, 2025

Mark if applicable

Uh oh!

Uh oh!

codecov bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gdesmott commented Jul 22, 2025

Uh oh!

gdesmott commented Jul 22, 2025

Uh oh!

chesedo commented Jul 22, 2025

Uh oh!

gdesmott commented Jul 28, 2025

Uh oh!

gdesmott commented Jul 31, 2025

Uh oh!

Uh oh!

gdesmott commented Aug 21, 2025

Uh oh!

Uh oh!

alonre24 commented Aug 21, 2025

Uh oh!

redisearch-backport-pull-request bot commented Aug 21, 2025

Uh oh!

alonre24 commented Aug 24, 2025

Uh oh!

redisearch-backport-pull-request bot commented Aug 24, 2025

Uh oh!

redisearch-backport-pull-request bot commented Aug 24, 2025

Uh oh!

redisearch-backport-pull-request bot commented Aug 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jul 21, 2025 •

edited

Loading