Add serialisation for svs + adjustments [MOD-10097]#6394
Merged
Conversation
todo: fix create error test, test info with quantised index
meiravgri
reviewed
Jun 30, 2025
GuyAv46
reviewed
Jun 30, 2025
alonre24
changed the title
alonre24
changed the title
GuyAv46
previously approved these changes
Jun 30, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6394 +/- ##
==========================================
+ Coverage 88.81% 89.21% +0.40%
==========================================
Files 251 251
Lines 41605 41307 -298
Branches 3623 3623
==========================================
- Hits 36953 36854 -99
+ Misses 4608 4409 -199
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ed in a different PR)
Collaborator
Author
alonre24
added a commit
to alonre24/redis
that referenced
this pull request
Jul 1, 2025
Introducing a new SVS-VAMANA vector type index which supports vector compression (optimized on Intel machines) - RediSearch/RediSearch#6329, RediSearch/RediSearch#6394
YaacovHazan
pushed a commit
to redis/redis
that referenced
this pull request
Jul 2, 2025
[#Q6329](RediSearch/RediSearch#6329), [#Q6329](RediSearch/RediSearch#6394) - Introducing the new SVS-VAMANA vector index type which supports vector compression (optimized on Intel machines)
fcostaoliveira
pushed a commit
to filipecosta90/redis
that referenced
this pull request
Jul 4, 2025
[#Q6329](RediSearch/RediSearch#6329), [#Q6329](RediSearch/RediSearch#6394) - Introducing the new SVS-VAMANA vector index type which supports vector compression (optimized on Intel machines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Adds required support for SVS-VAMANA, including:
initial_capandblock_sizeindex parameters as we used to in the past. Backward compatibility exists, though these args are ignored in practice.initial_capandblock_sizeso that index creation will not exceed memory limits. The logic was reduces and the minimum needed was left (validation that a single vector will not exceed the maximum block size allowed). Tests were also removed and adjusted.Main objects this PR modified
Mark if applicable