Skip to content

Fix lints that will be introduced in Rust 1.88.0#6374

Merged
LukeMathWalker merged 1 commit intomasterfrom
new-lints
Jul 2, 2025
Merged

Fix lints that will be introduced in Rust 1.88.0#6374
LukeMathWalker merged 1 commit intomasterfrom
new-lints

Conversation

@LukeMathWalker
Copy link
Collaborator

@LukeMathWalker LukeMathWalker commented Jun 25, 2025

Describe the changes in the pull request

Every new Rust release introduces new lints in clippy and the compiler itself.
This PR fixes the newly reported violations from 1.88.0.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@LukeMathWalker
Copy link
Collaborator Author

LukeMathWalker commented Jun 25, 2025

Keeping it as a draft, since we can't merge until 1.88.0 is released, given that let-chains aren't stable on 1.87.x.

@LukeMathWalker LukeMathWalker changed the title Fix lints that will be introduced in Rust 1.89.0 Fix lints that will be introduced in Rust 1.88.0 Jun 25, 2025
@LukeMathWalker LukeMathWalker marked this pull request as ready for review July 1, 2025 15:22
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (d6aa49c) to head (781d5fb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6374      +/-   ##
==========================================
- Coverage   89.26%   89.21%   -0.06%     
==========================================
  Files         251      251              
  Lines       41330    41298      -32     
  Branches     3623     3614       -9     
==========================================
- Hits        36895    36844      -51     
- Misses       4391     4410      +19     
  Partials       44       44              
Flag Coverage Δ
flow 81.92% <ø> (-0.18%) ⬇️
unit 46.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit that migth not be beneficial

@LukeMathWalker LukeMathWalker enabled auto-merge July 2, 2025 11:40
@LukeMathWalker LukeMathWalker added this pull request to the merge queue Jul 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2025
@LukeMathWalker LukeMathWalker added this pull request to the merge queue Jul 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2025
@LukeMathWalker LukeMathWalker added this pull request to the merge queue Jul 2, 2025
Merged via the queue into master with commit 96be547 Jul 2, 2025
15 checks passed
@LukeMathWalker LukeMathWalker deleted the new-lints branch July 2, 2025 15:52
@LukeMathWalker LukeMathWalker restored the new-lints branch February 6, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants