Skip to content

[2.10] MOD-10153: New APPLY function case() (#6332)#6356

Merged
oshadmi merged 6 commits into2.10from
nafraf_backport-6332-to-2.10
Jun 20, 2025
Merged

[2.10] MOD-10153: New APPLY function case() (#6332)#6356
oshadmi merged 6 commits into2.10from
nafraf_backport-6332-to-2.10

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented Jun 20, 2025 •
edited
Loading

Description

Backport of #6332 to 2.10.
(cherry picked from commit f338602)

Changes:

  • case() is guarded by UNSTABLE_FEATURES_ENABLE
  • Validate number of arguments of case() in evalFuncCase()
  • Free argList in case of error in the parser.

@nafraf nafraf marked this pull request as ready for review June 20, 2025 07:51
@codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (f7e5a6d) to head (5ce760f).
Report is 1 commits behind head on 2.10.

Files with missing lines Patch % Lines
src/aggregate/functions/string.c 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.10    #6356      +/-   ##
==========================================
+ Coverage   88.80%   88.82%   +0.02%     
==========================================
  Files         205      205              
  Lines       36267    36293      +26     
==========================================
+ Hits        32206    32238      +32     
+ Misses       4061     4055       -6
Flag Coverage Δ
flow 83.23% <92.85%> (-0.06%) ⬇️
unit 42.54% <78.57%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

oshadmi
oshadmi previously approved these changes Jun 20, 2025
View reviewed changes
@nafraf nafraf requested a review from oshadmi June 20, 2025 15:32
@oshadmi oshadmi added this pull request to the merge queue Jun 20, 2025
Merged via the queue into 2.10 with commit 5c09b69 Jun 20, 2025
9 checks passed
@oshadmi oshadmi deleted the nafraf_backport-6332-to-2.10 branch June 20, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oshadmi oshadmi oshadmi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nafraf @oshadmi